Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Unified Diff: components/offline_pages/offline_page_item.h

Issue 2484223005: Store original request URL in offline page metadata table (Closed)
Patch Set: Address feedback Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/offline_page_item.h
diff --git a/components/offline_pages/offline_page_item.h b/components/offline_pages/offline_page_item.h
index 72f43626affe5d7277eb61ad5eaeedf1dfed70af..2ec13e17998f440895d1dcba8550f5a38c9b1d13 100644
--- a/components/offline_pages/offline_page_item.h
+++ b/components/offline_pages/offline_page_item.h
@@ -59,7 +59,8 @@ struct OfflinePageItem {
// Returns whether the offline page is expired.
bool IsExpired() const;
- // The URL of the page.
+ // The URL of the page. This is the last committed URL. In the case that
+ // redirects occur, access |original_url| for the original URL.
GURL url;
// The primary key/ID for this page in offline pages internal database.
int64_t offline_id;
@@ -85,6 +86,9 @@ struct OfflinePageItem {
base::string16 title;
// Flags about the state and behavior of the offline page.
Flags flags;
+ // The original URL of the page if not empty. Otherwise, this is set to empty
+ // and |url| should be accessed instead.
+ GURL original_url;
};
} // namespace offline_pages
« no previous file with comments | « chrome/browser/ui/webui/offline/offline_internals_ui_message_handler.cc ('k') | components/offline_pages/offline_page_item.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698