Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Unified Diff: chrome/browser/android/offline_pages/recent_tab_helper.cc

Issue 2484223005: Store original request URL in offline page metadata table (Closed)
Patch Set: Address feedback Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/offline_pages/recent_tab_helper.cc
diff --git a/chrome/browser/android/offline_pages/recent_tab_helper.cc b/chrome/browser/android/offline_pages/recent_tab_helper.cc
index 0f723c58a9a9d7da26da2e3ef043964b5c7cb5c8..25b768235acf78a110ac6a3e8d6af708ae899bef 100644
--- a/chrome/browser/android/offline_pages/recent_tab_helper.cc
+++ b/chrome/browser/android/offline_pages/recent_tab_helper.cc
@@ -91,10 +91,12 @@ void RecentTabHelper::ObserveAndDownloadCurrentPage(
return;
// If snapshot already happened and we missed it, go ahead and snapshot now.
+ OfflinePageModel::SavePageParams save_page_params;
+ save_page_params.url = web_contents()->GetLastCommittedURL();
+ save_page_params.client_id = client_id;
+ save_page_params.proposed_offline_id = request_id;
page_model_->SavePage(
- web_contents()->GetLastCommittedURL(),
- client_id,
- request_id,
+ save_page_params,
delegate_->CreatePageArchiver(web_contents()),
base::Bind(&RecentTabHelper::SavePageCallback,
weak_ptr_factory_.GetWeakPtr()));
@@ -241,9 +243,11 @@ void RecentTabHelper::ContinueSnapshotAfterPurge(
return;
}
- page_model_->SavePage(snapshot_url_,
- download_info_->client_id_,
- download_info_->request_id_,
+ OfflinePageModel::SavePageParams save_page_params;
+ save_page_params.url = snapshot_url_;
+ save_page_params.client_id = download_info_->client_id_;
+ save_page_params.proposed_offline_id = download_info_->request_id_;
+ page_model_->SavePage(save_page_params,
delegate_->CreatePageArchiver(web_contents()),
base::Bind(&RecentTabHelper::SavePageCallback,
weak_ptr_factory_.GetWeakPtr()));

Powered by Google App Engine
This is Rietveld 408576698