Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2680)

Unified Diff: chrome/browser/android/offline_pages/prerendering_offliner.h

Issue 2484223005: Store original request URL in offline page metadata table (Closed)
Patch Set: Address feedback Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/offline_pages/prerendering_offliner.h
diff --git a/chrome/browser/android/offline_pages/prerendering_offliner.h b/chrome/browser/android/offline_pages/prerendering_offliner.h
index fd0f20a7966cad1f4ce71e6b9b493b7ae2b6756f..a259b069a68ccab743c0cc28621cbf9c662cb0a0 100644
--- a/chrome/browser/android/offline_pages/prerendering_offliner.h
+++ b/chrome/browser/android/offline_pages/prerendering_offliner.h
@@ -49,14 +49,12 @@ class PrerenderingOffliner : public Offliner {
protected:
// Internal method for requesting OfflinePageModel to save page. Exposed for
- // unit testing. |proposed_offline_id| will be used if non-zero. If it is
- // zero, a new, random, id will be generated instead.
+ // unit testing.
// TODO(dougarnett): Consider making OfflinePageModel mockable instead.
- virtual void SavePage(const GURL& url,
- const ClientId& client_id,
- int64_t proposed_offline_id,
- std::unique_ptr<OfflinePageArchiver> archiver,
- const SavePageCallback& save_callback);
+ virtual void SavePage(
+ const OfflinePageModel::SavePageParams& save_page_params,
+ std::unique_ptr<OfflinePageArchiver> archiver,
+ const SavePageCallback& save_callback);
private:
// Callback logic for PrerenderingLoader::LoadPage().

Powered by Google App Engine
This is Rietveld 408576698