Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Unified Diff: chrome/browser/android/offline_pages/offline_page_bridge.cc

Issue 2484223005: Store original request URL in offline page metadata table (Closed)
Patch Set: Address feedback Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/android/offline_pages/offline_page_request_job_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/offline_pages/offline_page_bridge.cc
diff --git a/chrome/browser/android/offline_pages/offline_page_bridge.cc b/chrome/browser/android/offline_pages/offline_page_bridge.cc
index f585cf6c7645666dfa404889356fb159bacf6af9..b5d81ffced343530ce4306898050ab18904dd026 100644
--- a/chrome/browser/android/offline_pages/offline_page_bridge.cc
+++ b/chrome/browser/android/offline_pages/offline_page_bridge.cc
@@ -429,23 +429,23 @@ void OfflinePageBridge::SavePage(
ScopedJavaGlobalRef<jobject> j_callback_ref;
j_callback_ref.Reset(env, j_callback_obj);
- GURL url;
+ OfflinePageModel::SavePageParams save_page_params;
std::unique_ptr<OfflinePageArchiver> archiver;
content::WebContents* web_contents =
content::WebContents::FromJavaWebContents(j_web_contents);
if (web_contents) {
- url = web_contents->GetLastCommittedURL();
+ save_page_params.url = web_contents->GetLastCommittedURL();
archiver.reset(new OfflinePageMHTMLArchiver(web_contents));
}
- offline_pages::ClientId client_id;
- client_id.name_space = ConvertJavaStringToUTF8(env, j_namespace);
- client_id.id = ConvertJavaStringToUTF8(env, j_client_id);
+ save_page_params.client_id.name_space =
+ ConvertJavaStringToUTF8(env, j_namespace);
+ save_page_params.client_id.id = ConvertJavaStringToUTF8(env, j_client_id);
offline_page_model_->SavePage(
- url, client_id, 0l, std::move(archiver),
- base::Bind(&SavePageCallback, j_callback_ref, url));
+ save_page_params, std::move(archiver),
+ base::Bind(&SavePageCallback, j_callback_ref, save_page_params.url));
}
void OfflinePageBridge::SavePageLater(JNIEnv* env,
« no previous file with comments | « no previous file | chrome/browser/android/offline_pages/offline_page_request_job_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698