Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Unified Diff: components/offline_pages/offline_page_model_impl.h

Issue 2484223005: Store original request URL in offline page metadata table (Closed)
Patch Set: Add and update tests Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/offline_page_model_impl.h
diff --git a/components/offline_pages/offline_page_model_impl.h b/components/offline_pages/offline_page_model_impl.h
index c0e76e5a8d6efe9fa7708bf43e35dc312ea7cbbb..c3aa3db5d93b9e0252752de6c49c1a1f7ffd723b 100644
--- a/components/offline_pages/offline_page_model_impl.h
+++ b/components/offline_pages/offline_page_model_impl.h
@@ -66,9 +66,7 @@ class OfflinePageModelImpl : public OfflinePageModel, public KeyedService {
// Implemented methods:
void AddObserver(Observer* observer) override;
void RemoveObserver(Observer* observer) override;
- void SavePage(const GURL& url,
- const ClientId& client_id,
- int64_t proposed_offline_id,
+ void SavePage(const SavePageInfo& save_page_info,
std::unique_ptr<OfflinePageArchiver> archiver,
const SavePageCallback& callback) override;
void MarkPageAccessed(int64_t offline_id) override;
@@ -153,9 +151,8 @@ class OfflinePageModelImpl : public OfflinePageModel, public KeyedService {
const std::vector<OfflinePageItem>& offline_pages);
// Steps for saving a page offline.
- void OnCreateArchiveDone(const GURL& requested_url,
+ void OnCreateArchiveDone(const SavePageInfo& save_page_info,
int64_t offline_id,
- const ClientId& client_id,
const base::Time& start_time,
const SavePageCallback& callback,
OfflinePageArchiver* archiver,

Powered by Google App Engine
This is Rietveld 408576698