Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(866)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js

Issue 2484213003: Convert performance monitor to the subscription model. (Closed)
Patch Set: same Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js b/third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js
index e7906e551fe0ba37709c9d5f89efc0e9b1afd583..652fbaafb03f856da16f3d33840e431ebab9a94d 100644
--- a/third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js
+++ b/third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js
@@ -50,8 +50,12 @@ WebInspector.ConsoleModel = class extends WebInspector.SDKModel {
if (this._logAgent) {
target.registerLogDispatcher(new WebInspector.LogDispatcher(this));
this._logAgent.enable();
- if (!InspectorFrontendHost.isUnderTest())
- this._logAgent.setReportViolationsEnabled(true);
+ if (!InspectorFrontendHost.isUnderTest()) {
+ this._logAgent.startViolationsReport([
+ {name: 'longTask', threshold: 50 },
caseq 2016/11/09 00:41:12 nit: I'd extract a static var for it and call it .
pfeldman 2016/11/09 01:39:14 Acknowledged.
+ {name: 'longLayout', threshold: 30},
+ {name: 'blockedEvent', threshold: 100}]);
+ }
}
}

Powered by Google App Engine
This is Rietveld 408576698