Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(540)

Issue 2484203002: Revert of Fix leak in FocusManager tests (Closed)

Created:
4 years, 1 month ago by henrika (OOO until Aug 14)
Modified:
4 years, 1 month ago
CC:
chromium-reviews, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix leak in FocusManager tests (patchset #1 id:1 of https://codereview.chromium.org/2483083002/ ) Reason for revert: Following recommendation from Findit to revert for breaking: FocusTraversalTest.TraversalWithInvisibleViews FocusTraversalTest.NormalTraversalMac FocusTraversalTest.PaneTraversal FocusTraversalTest.FullKeyboardToggle FocusTraversalTest.TraversalWithNonEnabledViews See https://findit-for-me.appspot.com/waterfall/build-failure?url=https://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Tests%20%281%29/builds/23999 Original issue's description: > Fix leak in FocusManager tests > > They create a widget and never destroy it. > > BUG=660994 > TEST=test only change > R=ben@chromium.org > > Committed: https://crrev.com/402f62030eda12d30ad6341e2774d9af2208bee1 > Cr-Commit-Position: refs/heads/master@{#430457} TBR=ben@chromium.org,sky@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=660994 Committed: https://crrev.com/2c0b086a6c010d8ef294c0791cf39a5f6f851564 Cr-Commit-Position: refs/heads/master@{#430585}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M ui/views/focus/focus_traversal_unittest.cc View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
henrika (OOO until Aug 14)
Created Revert of Fix leak in FocusManager tests
4 years, 1 month ago (2016-11-08 11:59:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2484203002/1
4 years, 1 month ago (2016-11-08 11:59:25 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-08 12:00:34 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/2c0b086a6c010d8ef294c0791cf39a5f6f851564 Cr-Commit-Position: refs/heads/master@{#430585}
4 years, 1 month ago (2016-11-08 12:02:21 UTC) #7
henrika (OOO until Aug 14)
4 years, 1 month ago (2016-11-08 13:29:53 UTC) #8
Message was sent while issue was closed.
FYI: The bot cycled green after this revert.

https://uberchromegw.corp.google.com/i/chromium.memory/builders/Mac%20ASan%20...

Powered by Google App Engine
This is Rietveld 408576698