[compiler] Whenever we want source positions, record that in the CompilationInfo.

[compiler] Whenever we want source positions, record that in the CompilationInfo.

With this CL, we set the is_source_positions_enabled flag on CompilationInfo when
- a command line flag is enabled that requires Turbofan to preserve source position
  information (e.g. --trace-deopt), and
- when profiling is enabled.

This also removes the --turbo-source-positions flag.

The goal is to eventually only track source position information when needed.

R=mstarzinger@chromium.org
BUG=v8:5439
Committed: https://crrev.com/083e465f3b2e7c9ef28eaf2b587ae1384a41e825
Cr-Commit-Position: refs/heads/master@{#40836}

[neis, 2016-11-08 12:32:27]

Description was changed from

==========
WIP

R=mstarzinger@chromium.org
BUG=
==========

to

==========
[compiler] Whenever we want source positions, record that in the
CompilationInfo.

With this CL, we set the is_source_positions_enabled flag on CompilationInfo
when
- a command line flag is enabled that requires Turbofan to preserve source
position
  information (e.g. --trace-deopt), and
- when profiling is enabled.

This also removes the --turbo-source-positions flag.

The goal is to eventually only track source position information when needed.

R=mstarzinger@chromium.org
BUG=v8:5439
==========

[neis, 2016-11-08 12:32:58]

neis@chromium.org changed reviewers:
+ yangguo@chromium.org

[neis, 2016-11-08 12:32:59]

ptal

[Yang, 2016-11-08 12:34:57]

lgtm.

just to be sure, there is no user for this compilation info flag yet, right?

[neis, 2016-11-08 12:37:21]

On 2016/11/08 12:34:57, Yang wrote:
> lgtm.
> 
> just to be sure, there is no user for this compilation info flag yet, right?

the flag is not new and there are two uses of it currently. there will be more
in the future.

[neis, 2016-11-08 12:37:23]

On 2016/11/08 12:34:57, Yang wrote:
> lgtm.
> 
> just to be sure, there is no user for this compilation info flag yet, right?

the flag is not new and there are two uses of it currently. there will be more
in the future.

[Yang, 2016-11-08 12:38:18]

On 2016/11/08 12:37:23, neis wrote:
> On 2016/11/08 12:34:57, Yang wrote:
> > lgtm.
> > 
> > just to be sure, there is no user for this compilation info flag yet, right?
> 
> the flag is not new and there are two uses of it currently. there will be more
> in the future.

I see. I suppose the part where we deoptimize all optimized code when profiling
starts will be in a follow-up CL?

[neis, 2016-11-08 13:33:34]

On 2016/11/08 12:38:18, Yang wrote:
> On 2016/11/08 12:37:23, neis wrote:
> > On 2016/11/08 12:34:57, Yang wrote:
> > > lgtm.
> > > 
> > > just to be sure, there is no user for this compilation info flag yet,
right?
> > 
> > the flag is not new and there are two uses of it currently. there will be
more
> > in the future.
> 
> I see. I suppose the part where we deoptimize all optimized code when
profiling
> starts will be in a follow-up CL?

Yes.

[neis, 2016-11-08 13:33:48]

The CQ bit was checked by neis@chromium.org

[commit-bot: I haz the power, 2016-11-08 13:33:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-08 14:01:38]

Description was changed from

==========
[compiler] Whenever we want source positions, record that in the
CompilationInfo.

With this CL, we set the is_source_positions_enabled flag on CompilationInfo
when
- a command line flag is enabled that requires Turbofan to preserve source
position
  information (e.g. --trace-deopt), and
- when profiling is enabled.

This also removes the --turbo-source-positions flag.

The goal is to eventually only track source position information when needed.

R=mstarzinger@chromium.org
BUG=v8:5439
==========

to

==========
[compiler] Whenever we want source positions, record that in the
CompilationInfo.

With this CL, we set the is_source_positions_enabled flag on CompilationInfo
when
- a command line flag is enabled that requires Turbofan to preserve source
position
  information (e.g. --trace-deopt), and
- when profiling is enabled.

This also removes the --turbo-source-positions flag.

The goal is to eventually only track source position information when needed.

R=mstarzinger@chromium.org
BUG=v8:5439
==========

[commit-bot: I haz the power, 2016-11-08 14:01:39]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-17 22:26:14]

Description was changed from

==========
[compiler] Whenever we want source positions, record that in the
CompilationInfo.

With this CL, we set the is_source_positions_enabled flag on CompilationInfo
when
- a command line flag is enabled that requires Turbofan to preserve source
position
  information (e.g. --trace-deopt), and
- when profiling is enabled.

This also removes the --turbo-source-positions flag.

The goal is to eventually only track source position information when needed.

R=mstarzinger@chromium.org
BUG=v8:5439
==========

to

==========
[compiler] Whenever we want source positions, record that in the
CompilationInfo.

With this CL, we set the is_source_positions_enabled flag on CompilationInfo
when
- a command line flag is enabled that requires Turbofan to preserve source
position
  information (e.g. --trace-deopt), and
- when profiling is enabled.

This also removes the --turbo-source-positions flag.

The goal is to eventually only track source position information when needed.

R=mstarzinger@chromium.org
BUG=v8:5439

Committed: https://crrev.com/083e465f3b2e7c9ef28eaf2b587ae1384a41e825
Cr-Commit-Position: refs/heads/master@{#40836}
==========

[commit-bot: I haz the power, 2016-11-17 22:26:16]

Patchset 1 (id:??) landed as
https://crrev.com/083e465f3b2e7c9ef28eaf2b587ae1384a41e825
Cr-Commit-Position: refs/heads/master@{#40836}