Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(586)

Unified Diff: third_party/WebKit/Source/core/paint/PaintLayerResourceInfo.h

Issue 2484153003: Use an SVGElementProxy in ReferenceClipPathOperation (Closed)
Patch Set: Rebase; fix comments; findElement Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/paint/PaintLayerResourceInfo.h
diff --git a/third_party/WebKit/Source/core/paint/PaintLayerFilterInfo.h b/third_party/WebKit/Source/core/paint/PaintLayerResourceInfo.h
similarity index 79%
rename from third_party/WebKit/Source/core/paint/PaintLayerFilterInfo.h
rename to third_party/WebKit/Source/core/paint/PaintLayerResourceInfo.h
index 8805083ba956ff4e08e3b4a223effe485f5f5e71..5b207e0e2c77b8965a96063bf92f757e21677f64 100644
--- a/third_party/WebKit/Source/core/paint/PaintLayerFilterInfo.h
+++ b/third_party/WebKit/Source/core/paint/PaintLayerResourceInfo.h
@@ -27,8 +27,8 @@
* SUCH DAMAGE.
*/
-#ifndef PaintLayerFilterInfo_h
-#define PaintLayerFilterInfo_h
+#ifndef PaintLayerResourceInfo_h
+#define PaintLayerResourceInfo_h
#include "core/svg/SVGResourceClient.h"
#include "platform/heap/Handle.h"
@@ -39,24 +39,24 @@ namespace blink {
class FilterEffect;
class PaintLayer;
-// PaintLayerFilterInfo holds the filter information for painting.
-// https://drafts.fxtf.org/filters/
+// PaintLayerResourceInfo holds the filter information for painting
+// https://drafts.fxtf.org/filters/. It also acts as the resource client for
+// change notifications from <clipPath> elements for the clip-path property.
//
// Because PaintLayer is not allocated for SVG objects, SVG filters (both
// software and hardware-accelerated) use a different code path to paint the
// filters (SVGFilterPainter), but both code paths use the same abstraction for
// painting non-hardware accelerated filters (FilterEffect). Hardware
// accelerated CSS filters use CompositorFilterOperations, that is backed by cc.
-//
-class PaintLayerFilterInfo final
- : public GarbageCollectedFinalized<PaintLayerFilterInfo>,
+class PaintLayerResourceInfo final
+ : public GarbageCollectedFinalized<PaintLayerResourceInfo>,
public SVGResourceClient {
- WTF_MAKE_NONCOPYABLE(PaintLayerFilterInfo);
- USING_GARBAGE_COLLECTED_MIXIN(PaintLayerFilterInfo);
+ WTF_MAKE_NONCOPYABLE(PaintLayerResourceInfo);
+ USING_GARBAGE_COLLECTED_MIXIN(PaintLayerResourceInfo);
public:
- explicit PaintLayerFilterInfo(PaintLayer*);
- ~PaintLayerFilterInfo() override;
+ explicit PaintLayerResourceInfo(PaintLayer*);
+ ~PaintLayerResourceInfo() override;
void setLastEffect(FilterEffect*);
FilterEffect* lastEffect() const;
@@ -79,4 +79,4 @@ class PaintLayerFilterInfo final
} // namespace blink
-#endif // PaintLayerFilterInfo_h
+#endif // PaintLayerResourceInfo_h

Powered by Google App Engine
This is Rietveld 408576698