Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(685)

Issue 2484043004: Apply Delayed Code Review Comments to Task Scheduler Internals (Closed)

Created:
4 years, 1 month ago by robliao
Modified:
4 years, 1 month ago
Reviewers:
Dan Beam
CC:
chromium-reviews, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Apply Delayed Code Review Comments to Task Scheduler Internals The comments originate from http://codereview.chromium.org/2420973002/ BUG=553459 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/5257b498824c70d2d7440f8dbb7960ac59ea9c7b Cr-Commit-Position: refs/heads/master@{#431021}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -55 lines) Patch
M chrome/browser/resources/task_scheduler_internals/index.js View 1 chunk +60 lines, -54 lines 0 comments Download
M chrome/browser/ui/webui/task_scheduler_internals/task_scheduler_internals_ui.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 14 (9 generated)
robliao
dbeam: Please review this CL. Thanks!
4 years, 1 month ago (2016-11-08 18:14:43 UTC) #3
Dan Beam
lgtm thanks for the clean up!
4 years, 1 month ago (2016-11-09 17:37:51 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2484043004/1
4 years, 1 month ago (2016-11-09 18:17:19 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-09 20:21:49 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-09 20:33:08 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5257b498824c70d2d7440f8dbb7960ac59ea9c7b
Cr-Commit-Position: refs/heads/master@{#431021}

Powered by Google App Engine
This is Rietveld 408576698