Revert of Clean up some NativeTheme code.

Revert of Clean up some NativeTheme code. (patchset #2 id:20001 of https://codereview.chromium.org/2480993002/ )

Reason for revert:
Scroll bars are appearing as errors in layout tests: e.g.
fast/forms/select/listbox-appearance-basic.html

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fast%2Fforms%2Fselect%2Flistbox-appearance-basic.html&testType=webkit_tests

This rollback is speculative, but there are few possibilities in the blame list
https://chromium.googlesource.com/chromium/src/+log/40639df0c3a5e05761a846b2fe116961d87c9c62%5E..99453a7509f05ca729e66d774f5ae2817c3988c3?pretty=fuller

Original issue's description:
> Clean up some NativeTheme code.
>
> - improve instantiation
> - allow to specify separate instances for web and native
> - two NativeThemeAura instances coexist for w/wo overlay scrollbars
>
> BUG=307091
>
> Committed: https://crrev.com/99453a7509f05ca729e66d774f5ae2817c3988c3
> Cr-Commit-Position: refs/heads/master@{#430381}

TBR=sky@chromium.org,bokan@chromium.org,estade@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=307091
Committed: https://crrev.com/c3f70e203cedca00c51cb353b6e6a4c3184ae3b5
Cr-Commit-Position: refs/heads/master@{#430463}

[scheib, 2016-11-08 01:25:17]

The CQ bit was checked by scheib@chromium.org

[scheib, 2016-11-08 01:25:17]

Created Revert of Clean up some NativeTheme code.

[commit-bot: I haz the power, 2016-11-08 01:25:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-08 01:27:15]

Description was changed from

==========
Revert of Clean up some NativeTheme code. (patchset #2 id:20001 of
https://codereview.chromium.org/2480993002/ )

Reason for revert:
Scroll bars are appearing as errors in layout tests: e.g.
fast/forms/select/listbox-appearance-basic.html

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fa...

This rollback is speculative, but there are few possibilities in the blame list
https://chromium.googlesource.com/chromium/src/+log/40639df0c3a5e05761a846b2f...

Original issue's description:
> Clean up some NativeTheme code.
> 
> - improve instantiation
> - allow to specify separate instances for web and native
> - two NativeThemeAura instances coexist for w/wo overlay scrollbars
> 
> BUG=307091
> 
> Committed: https://crrev.com/99453a7509f05ca729e66d774f5ae2817c3988c3
> Cr-Commit-Position: refs/heads/master@{#430381}

TBR=sky@chromium.org,bokan@chromium.org,estade@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=307091
==========

to

==========
Revert of Clean up some NativeTheme code. (patchset #2 id:20001 of
https://codereview.chromium.org/2480993002/ )

Reason for revert:
Scroll bars are appearing as errors in layout tests: e.g.
fast/forms/select/listbox-appearance-basic.html

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fa...

This rollback is speculative, but there are few possibilities in the blame list
https://chromium.googlesource.com/chromium/src/+log/40639df0c3a5e05761a846b2f...

Original issue's description:
> Clean up some NativeTheme code.
> 
> - improve instantiation
> - allow to specify separate instances for web and native
> - two NativeThemeAura instances coexist for w/wo overlay scrollbars
> 
> BUG=307091
> 
> Committed: https://crrev.com/99453a7509f05ca729e66d774f5ae2817c3988c3
> Cr-Commit-Position: refs/heads/master@{#430381}

TBR=sky@chromium.org,bokan@chromium.org,estade@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=307091
==========

[commit-bot: I haz the power, 2016-11-08 01:27:16]

Committed patchset #1 (id:1)

[Evan Stade, 2016-11-08 01:36:40]

https://codereview.chromium.org/2484043003/diff/1/ui/native_theme/native_them...
File ui/native_theme/native_theme_aura.cc (left):

https://codereview.chromium.org/2484043003/diff/1/ui/native_theme/native_them...
ui/native_theme/native_theme_aura.cc:201: thumb_alpha = overlay ?
kOverlayScrollbarAlphaPressed : 0x80;
the bug is no breaks in this switch :[

[commit-bot: I haz the power, 2016-11-08 01:37:58]

Description was changed from

==========
Revert of Clean up some NativeTheme code. (patchset #2 id:20001 of
https://codereview.chromium.org/2480993002/ )

Reason for revert:
Scroll bars are appearing as errors in layout tests: e.g.
fast/forms/select/listbox-appearance-basic.html

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fa...

This rollback is speculative, but there are few possibilities in the blame list
https://chromium.googlesource.com/chromium/src/+log/40639df0c3a5e05761a846b2f...

Original issue's description:
> Clean up some NativeTheme code.
> 
> - improve instantiation
> - allow to specify separate instances for web and native
> - two NativeThemeAura instances coexist for w/wo overlay scrollbars
> 
> BUG=307091
> 
> Committed: https://crrev.com/99453a7509f05ca729e66d774f5ae2817c3988c3
> Cr-Commit-Position: refs/heads/master@{#430381}

TBR=sky@chromium.org,bokan@chromium.org,estade@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=307091
==========

to

==========
Revert of Clean up some NativeTheme code. (patchset #2 id:20001 of
https://codereview.chromium.org/2480993002/ )

Reason for revert:
Scroll bars are appearing as errors in layout tests: e.g.
fast/forms/select/listbox-appearance-basic.html

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fa...

This rollback is speculative, but there are few possibilities in the blame list
https://chromium.googlesource.com/chromium/src/+log/40639df0c3a5e05761a846b2f...

Original issue's description:
> Clean up some NativeTheme code.
>
> - improve instantiation
> - allow to specify separate instances for web and native
> - two NativeThemeAura instances coexist for w/wo overlay scrollbars
>
> BUG=307091
>
> Committed: https://crrev.com/99453a7509f05ca729e66d774f5ae2817c3988c3
> Cr-Commit-Position: refs/heads/master@{#430381}

TBR=sky@chromium.org,bokan@chromium.org,estade@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=307091

Committed: https://crrev.com/c3f70e203cedca00c51cb353b6e6a4c3184ae3b5
Cr-Commit-Position: refs/heads/master@{#430463}
==========

[commit-bot: I haz the power, 2016-11-08 01:37:58]

Patchset 1 (id:??) landed as
https://crrev.com/c3f70e203cedca00c51cb353b6e6a4c3184ae3b5
Cr-Commit-Position: refs/heads/master@{#430463}