Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Unified Diff: core/fpdfapi/parser/cpdf_stream.h

Issue 2484033002: Return unique_ptr from CPDF_Object::Clone(). (Closed)
Patch Set: Be painfully obvious about hidden expression Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: core/fpdfapi/parser/cpdf_stream.h
diff --git a/core/fpdfapi/parser/cpdf_stream.h b/core/fpdfapi/parser/cpdf_stream.h
index f0ba31924e4147c82dce91e88d1d42b9c80ce9a3..ddf7cc5b693e69a3b5c36063ec36c0fcd42172fb 100644
--- a/core/fpdfapi/parser/cpdf_stream.h
+++ b/core/fpdfapi/parser/cpdf_stream.h
@@ -22,9 +22,9 @@ class CPDF_Stream : public CPDF_Object {
CPDF_Stream(uint8_t* pData, uint32_t size, CPDF_Dictionary* pDict);
~CPDF_Stream() override;
- // CPDF_Object.
+ // CPDF_Object:
Type GetType() const override;
- CPDF_Object* Clone() const override;
+ std::unique_ptr<CPDF_Object> Clone() const override;
CPDF_Dictionary* GetDict() const override;
CFX_WideString GetUnicodeText() const override;
bool IsStream() const override;
@@ -48,7 +48,7 @@ class CPDF_Stream : public CPDF_Object {
bool IsMemoryBased() const { return m_bMemoryBased; }
protected:
- CPDF_Object* CloneNonCyclic(
+ std::unique_ptr<CPDF_Object> CloneNonCyclic(
bool bDirect,
std::set<const CPDF_Object*>* pVisited) const override;

Powered by Google App Engine
This is Rietveld 408576698