Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2810)

Unified Diff: core/fpdfapi/parser/cpdf_number.cpp

Issue 2484033002: Return unique_ptr from CPDF_Object::Clone(). (Closed)
Patch Set: std::move() it Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « core/fpdfapi/parser/cpdf_number.h ('k') | core/fpdfapi/parser/cpdf_object.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: core/fpdfapi/parser/cpdf_number.cpp
diff --git a/core/fpdfapi/parser/cpdf_number.cpp b/core/fpdfapi/parser/cpdf_number.cpp
index 3ae629ede92a57316334b88f2975e51ba9471ebe..24feb2a2e0584256cec2658e317b24217c753f91 100644
--- a/core/fpdfapi/parser/cpdf_number.cpp
+++ b/core/fpdfapi/parser/cpdf_number.cpp
@@ -5,6 +5,7 @@
// Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
#include "core/fpdfapi/parser/cpdf_number.h"
+#include "third_party/base/ptr_util.h"
CPDF_Number::CPDF_Number() : m_bInteger(true), m_Integer(0) {}
@@ -21,8 +22,9 @@ CPDF_Object::Type CPDF_Number::GetType() const {
return NUMBER;
}
-CPDF_Object* CPDF_Number::Clone() const {
- return m_bInteger ? new CPDF_Number(m_Integer) : new CPDF_Number(m_Float);
+std::unique_ptr<CPDF_Object> CPDF_Number::Clone() const {
+ return m_bInteger ? pdfium::MakeUnique<CPDF_Number>(m_Integer)
+ : pdfium::MakeUnique<CPDF_Number>(m_Float);
}
FX_FLOAT CPDF_Number::GetNumber() const {
« no previous file with comments | « core/fpdfapi/parser/cpdf_number.h ('k') | core/fpdfapi/parser/cpdf_object.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698