Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Side by Side Diff: core/fpdfapi/parser/cpdf_reference.h

Issue 2484033002: Return unique_ptr from CPDF_Object::Clone(). (Closed)
Patch Set: std::move() it Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « core/fpdfapi/parser/cpdf_parser.cpp ('k') | core/fpdfapi/parser/cpdf_reference.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 PDFium Authors. All rights reserved. 1 // Copyright 2016 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #ifndef CORE_FPDFAPI_PARSER_CPDF_REFERENCE_H_ 7 #ifndef CORE_FPDFAPI_PARSER_CPDF_REFERENCE_H_
8 #define CORE_FPDFAPI_PARSER_CPDF_REFERENCE_H_ 8 #define CORE_FPDFAPI_PARSER_CPDF_REFERENCE_H_
9 9
10 #include <set> 10 #include <set>
11 11
12 #include "core/fpdfapi/parser/cpdf_object.h" 12 #include "core/fpdfapi/parser/cpdf_object.h"
13 13
14 class CPDF_IndirectObjectHolder; 14 class CPDF_IndirectObjectHolder;
15 15
16 class CPDF_Reference : public CPDF_Object { 16 class CPDF_Reference : public CPDF_Object {
17 public: 17 public:
18 CPDF_Reference(CPDF_IndirectObjectHolder* pDoc, int objnum); 18 CPDF_Reference(CPDF_IndirectObjectHolder* pDoc, int objnum);
19 ~CPDF_Reference() override; 19 ~CPDF_Reference() override;
20 20
21 // CPDF_Object. 21 // CPDF_Object:
22 Type GetType() const override; 22 Type GetType() const override;
23 CPDF_Object* Clone() const override; 23 std::unique_ptr<CPDF_Object> Clone() const override;
24 CPDF_Object* GetDirect() const override; 24 CPDF_Object* GetDirect() const override;
25 CFX_ByteString GetString() const override; 25 CFX_ByteString GetString() const override;
26 FX_FLOAT GetNumber() const override; 26 FX_FLOAT GetNumber() const override;
27 int GetInteger() const override; 27 int GetInteger() const override;
28 CPDF_Dictionary* GetDict() const override; 28 CPDF_Dictionary* GetDict() const override;
29 bool IsReference() const override; 29 bool IsReference() const override;
30 CPDF_Reference* AsReference() override; 30 CPDF_Reference* AsReference() override;
31 const CPDF_Reference* AsReference() const override; 31 const CPDF_Reference* AsReference() const override;
32 32
33 CPDF_IndirectObjectHolder* GetObjList() const { return m_pObjList; } 33 CPDF_IndirectObjectHolder* GetObjList() const { return m_pObjList; }
34 uint32_t GetRefObjNum() const { return m_RefObjNum; } 34 uint32_t GetRefObjNum() const { return m_RefObjNum; }
35 35
36 void SetRef(CPDF_IndirectObjectHolder* pDoc, uint32_t objnum); 36 void SetRef(CPDF_IndirectObjectHolder* pDoc, uint32_t objnum);
37 37
38 protected: 38 protected:
39 CPDF_Object* CloneNonCyclic( 39 std::unique_ptr<CPDF_Object> CloneNonCyclic(
40 bool bDirect, 40 bool bDirect,
41 std::set<const CPDF_Object*>* pVisited) const override; 41 std::set<const CPDF_Object*>* pVisited) const override;
42 CPDF_Object* SafeGetDirect() const; 42 CPDF_Object* SafeGetDirect() const;
43 43
44 CPDF_IndirectObjectHolder* m_pObjList; 44 CPDF_IndirectObjectHolder* m_pObjList;
45 uint32_t m_RefObjNum; 45 uint32_t m_RefObjNum;
46 }; 46 };
47 47
48 inline CPDF_Reference* ToReference(CPDF_Object* obj) { 48 inline CPDF_Reference* ToReference(CPDF_Object* obj) {
49 return obj ? obj->AsReference() : nullptr; 49 return obj ? obj->AsReference() : nullptr;
50 } 50 }
51 51
52 inline const CPDF_Reference* ToReference(const CPDF_Object* obj) { 52 inline const CPDF_Reference* ToReference(const CPDF_Object* obj) {
53 return obj ? obj->AsReference() : nullptr; 53 return obj ? obj->AsReference() : nullptr;
54 } 54 }
55 55
56 #endif // CORE_FPDFAPI_PARSER_CPDF_REFERENCE_H_ 56 #endif // CORE_FPDFAPI_PARSER_CPDF_REFERENCE_H_
OLDNEW
« no previous file with comments | « core/fpdfapi/parser/cpdf_parser.cpp ('k') | core/fpdfapi/parser/cpdf_reference.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698