Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Side by Side Diff: core/fpdfapi/parser/cpdf_name.h

Issue 2484033002: Return unique_ptr from CPDF_Object::Clone(). (Closed)
Patch Set: std::move() it Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « core/fpdfapi/parser/cpdf_dictionary.cpp ('k') | core/fpdfapi/parser/cpdf_name.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 PDFium Authors. All rights reserved. 1 // Copyright 2016 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #ifndef CORE_FPDFAPI_PARSER_CPDF_NAME_H_ 7 #ifndef CORE_FPDFAPI_PARSER_CPDF_NAME_H_
8 #define CORE_FPDFAPI_PARSER_CPDF_NAME_H_ 8 #define CORE_FPDFAPI_PARSER_CPDF_NAME_H_
9 9
10 #include "core/fpdfapi/parser/cpdf_object.h" 10 #include "core/fpdfapi/parser/cpdf_object.h"
11 11
12 class CPDF_Name : public CPDF_Object { 12 class CPDF_Name : public CPDF_Object {
13 public: 13 public:
14 explicit CPDF_Name(const CFX_ByteString& str); 14 explicit CPDF_Name(const CFX_ByteString& str);
15 ~CPDF_Name() override; 15 ~CPDF_Name() override;
16 16
17 // CPDF_Object: 17 // CPDF_Object:
18 Type GetType() const override; 18 Type GetType() const override;
19 CPDF_Object* Clone() const override; 19 std::unique_ptr<CPDF_Object> Clone() const override;
20 CFX_ByteString GetString() const override; 20 CFX_ByteString GetString() const override;
21 CFX_WideString GetUnicodeText() const override; 21 CFX_WideString GetUnicodeText() const override;
22 void SetString(const CFX_ByteString& str) override; 22 void SetString(const CFX_ByteString& str) override;
23 bool IsName() const override; 23 bool IsName() const override;
24 CPDF_Name* AsName() override; 24 CPDF_Name* AsName() override;
25 const CPDF_Name* AsName() const override; 25 const CPDF_Name* AsName() const override;
26 26
27 protected: 27 protected:
28 CFX_ByteString m_Name; 28 CFX_ByteString m_Name;
29 }; 29 };
30 30
31 inline CPDF_Name* ToName(CPDF_Object* obj) { 31 inline CPDF_Name* ToName(CPDF_Object* obj) {
32 return obj ? obj->AsName() : nullptr; 32 return obj ? obj->AsName() : nullptr;
33 } 33 }
34 34
35 inline const CPDF_Name* ToName(const CPDF_Object* obj) { 35 inline const CPDF_Name* ToName(const CPDF_Object* obj) {
36 return obj ? obj->AsName() : nullptr; 36 return obj ? obj->AsName() : nullptr;
37 } 37 }
38 38
39 #endif // CORE_FPDFAPI_PARSER_CPDF_NAME_H_ 39 #endif // CORE_FPDFAPI_PARSER_CPDF_NAME_H_
OLDNEW
« no previous file with comments | « core/fpdfapi/parser/cpdf_dictionary.cpp ('k') | core/fpdfapi/parser/cpdf_name.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698