Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: core/fpdfapi/parser/cpdf_name.cpp

Issue 2484033002: Return unique_ptr from CPDF_Object::Clone(). (Closed)
Patch Set: std::move() it Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « core/fpdfapi/parser/cpdf_name.h ('k') | core/fpdfapi/parser/cpdf_null.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 PDFium Authors. All rights reserved. 1 // Copyright 2016 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #include "core/fpdfapi/parser/cpdf_name.h" 7 #include "core/fpdfapi/parser/cpdf_name.h"
8 8
9 #include "core/fpdfapi/parser/fpdf_parser_decode.h" 9 #include "core/fpdfapi/parser/fpdf_parser_decode.h"
10 #include "third_party/base/ptr_util.h"
10 11
11 CPDF_Name::CPDF_Name(const CFX_ByteString& str) : m_Name(str) {} 12 CPDF_Name::CPDF_Name(const CFX_ByteString& str) : m_Name(str) {}
12 13
13 CPDF_Name::~CPDF_Name() {} 14 CPDF_Name::~CPDF_Name() {}
14 15
15 CPDF_Object::Type CPDF_Name::GetType() const { 16 CPDF_Object::Type CPDF_Name::GetType() const {
16 return NAME; 17 return NAME;
17 } 18 }
18 19
19 CPDF_Object* CPDF_Name::Clone() const { 20 std::unique_ptr<CPDF_Object> CPDF_Name::Clone() const {
20 return new CPDF_Name(m_Name); 21 return pdfium::MakeUnique<CPDF_Name>(m_Name);
21 } 22 }
22 23
23 CFX_ByteString CPDF_Name::GetString() const { 24 CFX_ByteString CPDF_Name::GetString() const {
24 return m_Name; 25 return m_Name;
25 } 26 }
26 27
27 void CPDF_Name::SetString(const CFX_ByteString& str) { 28 void CPDF_Name::SetString(const CFX_ByteString& str) {
28 m_Name = str; 29 m_Name = str;
29 } 30 }
30 31
31 bool CPDF_Name::IsName() const { 32 bool CPDF_Name::IsName() const {
32 return true; 33 return true;
33 } 34 }
34 35
35 CPDF_Name* CPDF_Name::AsName() { 36 CPDF_Name* CPDF_Name::AsName() {
36 return this; 37 return this;
37 } 38 }
38 39
39 const CPDF_Name* CPDF_Name::AsName() const { 40 const CPDF_Name* CPDF_Name::AsName() const {
40 return this; 41 return this;
41 } 42 }
42 43
43 CFX_WideString CPDF_Name::GetUnicodeText() const { 44 CFX_WideString CPDF_Name::GetUnicodeText() const {
44 return PDF_DecodeText(m_Name); 45 return PDF_DecodeText(m_Name);
45 } 46 }
OLDNEW
« no previous file with comments | « core/fpdfapi/parser/cpdf_name.h ('k') | core/fpdfapi/parser/cpdf_null.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698