Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Side by Side Diff: core/fpdfapi/parser/cpdf_boolean.cpp

Issue 2484033002: Return unique_ptr from CPDF_Object::Clone(). (Closed)
Patch Set: std::move() it Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « core/fpdfapi/parser/cpdf_boolean.h ('k') | core/fpdfapi/parser/cpdf_dictionary.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 PDFium Authors. All rights reserved. 1 // Copyright 2016 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #include "core/fpdfapi/parser/cpdf_boolean.h" 7 #include "core/fpdfapi/parser/cpdf_boolean.h"
8 #include "third_party/base/ptr_util.h"
8 9
9 CPDF_Boolean::CPDF_Boolean() : m_bValue(false) {} 10 CPDF_Boolean::CPDF_Boolean() : m_bValue(false) {}
10 11
11 CPDF_Boolean::CPDF_Boolean(bool value) : m_bValue(value) {} 12 CPDF_Boolean::CPDF_Boolean(bool value) : m_bValue(value) {}
12 13
13 CPDF_Boolean::~CPDF_Boolean() {} 14 CPDF_Boolean::~CPDF_Boolean() {}
14 15
15 CPDF_Object::Type CPDF_Boolean::GetType() const { 16 CPDF_Object::Type CPDF_Boolean::GetType() const {
16 return BOOLEAN; 17 return BOOLEAN;
17 } 18 }
18 19
19 CPDF_Object* CPDF_Boolean::Clone() const { 20 std::unique_ptr<CPDF_Object> CPDF_Boolean::Clone() const {
20 return new CPDF_Boolean(m_bValue); 21 return pdfium::MakeUnique<CPDF_Boolean>(m_bValue);
21 } 22 }
22 23
23 CFX_ByteString CPDF_Boolean::GetString() const { 24 CFX_ByteString CPDF_Boolean::GetString() const {
24 return m_bValue ? "true" : "false"; 25 return m_bValue ? "true" : "false";
25 } 26 }
26 27
27 int CPDF_Boolean::GetInteger() const { 28 int CPDF_Boolean::GetInteger() const {
28 return m_bValue; 29 return m_bValue;
29 } 30 }
30 31
31 void CPDF_Boolean::SetString(const CFX_ByteString& str) { 32 void CPDF_Boolean::SetString(const CFX_ByteString& str) {
32 m_bValue = (str == "true"); 33 m_bValue = (str == "true");
33 } 34 }
34 35
35 bool CPDF_Boolean::IsBoolean() const { 36 bool CPDF_Boolean::IsBoolean() const {
36 return true; 37 return true;
37 } 38 }
38 39
39 CPDF_Boolean* CPDF_Boolean::AsBoolean() { 40 CPDF_Boolean* CPDF_Boolean::AsBoolean() {
40 return this; 41 return this;
41 } 42 }
42 43
43 const CPDF_Boolean* CPDF_Boolean::AsBoolean() const { 44 const CPDF_Boolean* CPDF_Boolean::AsBoolean() const {
44 return this; 45 return this;
45 } 46 }
OLDNEW
« no previous file with comments | « core/fpdfapi/parser/cpdf_boolean.h ('k') | core/fpdfapi/parser/cpdf_dictionary.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698