Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2484013002:
Make SurfaceFactory lifetime match frame_sink_id_ registration in RWHVChildFrame (Closed)
|
Created:
4 years, 1 month ago by piman Modified:
4 years, 1 month ago Reviewers:
Fady Samuel CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, darin-cc_chromium.org, creis+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMake SurfaceFactory lifetime match frame_sink_id_ registration in RWHVChildFrame
This will allow further simplification/refactoring.
BUG=657959
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
Committed: https://crrev.com/caabb8122c93adfa618f0acb8cf4ce8445c0e52a
Cr-Commit-Position: refs/heads/master@{#430947}
Patch Set 1 #Patch Set 2 : Fix null frame on compositor change #Patch Set 3 : Fix RenderWidgetHostViewGuest #
Messages
Total messages: 27 (16 generated)
Description was changed from ========== Make SurfaceFactory lifetime match frame_sink_id_ registration in RWHVChildFrame This will allow further simplification/refactoring. BUG=657959 ========== to ========== Make SurfaceFactory lifetime match frame_sink_id_ registration in RWHVChildFrame This will allow further simplification/refactoring. BUG=657959 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation ==========
The CQ bit was checked by piman@chromium.org to run a CQ dry run
piman@chromium.org changed reviewers: + fsamuel@chromium.org
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by piman@chromium.org
The CQ bit was checked by piman@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by piman@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from fsamuel@chromium.org Link to the patchset: https://codereview.chromium.org/2484013002/#ps20001 (title: "Fix null frame on compositor change")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by piman@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
fsamuel: PTAL - RWHVGuest needed an equivalent fix, because it inherits from RWHVChildFrame but reimplements the surface handling ( :(( )
lgtm. Sigh, yea, I noticed that before. We need to unify :(
The CQ bit was checked by piman@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Make SurfaceFactory lifetime match frame_sink_id_ registration in RWHVChildFrame This will allow further simplification/refactoring. BUG=657959 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation ========== to ========== Make SurfaceFactory lifetime match frame_sink_id_ registration in RWHVChildFrame This will allow further simplification/refactoring. BUG=657959 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/caabb8122c93adfa618f0acb8cf4ce8445c0e52a Cr-Commit-Position: refs/heads/master@{#430947} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/caabb8122c93adfa618f0acb8cf4ce8445c0e52a Cr-Commit-Position: refs/heads/master@{#430947} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
