src/isolate.cc - Issue 2484003002: [builtins] implement JSBuiltinReducer for ArrayIteratorNext()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/isolate.cc

Issue 2484003002: [builtins] implement JSBuiltinReducer for ArrayIteratorNext() (Closed)

Patch Set: add (some) test coverage, and fix some bugs found by it Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/isolate.cc

diff --git a/src/isolate.cc b/src/isolate.cc

index b0139a70a68e4fc4f32bdf94c4833cc233087986..f66344cfe9c7a5cd827c504cd2591d9751f01946 100644

--- a/src/isolate.cc

+++ b/src/isolate.cc

@@ -2953,6 +2953,14 @@ void Isolate::InvalidateStringLengthOverflowProtector() {

DCHECK(!IsStringLengthOverflowIntact());

}

+void Isolate::InvalidateArrayIteratorProtector() {

+ DCHECK(factory()->array_iterator_protector()->value()->IsSmi());

+ DCHECK(CanInlineArrayIterator());

+ factory()->array_iterator_protector()->set_value(

+ Smi::FromInt(kArrayProtectorInvalid));

+ DCHECK(!CanInlineArrayIterator());

bool Isolate::IsAnyInitialArrayPrototype(Handle<JSArray> array) {

DisallowHeapAllocation no_gc;

return IsInAnyContext(*array, Context::INITIAL_ARRAY_PROTOTYPE_INDEX);