Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Unified Diff: src/compiler/access-builder.cc

Issue 2484003002: [builtins] implement JSBuiltinReducer for ArrayIteratorNext() (Closed)
Patch Set: add (some) test coverage, and fix some bugs found by it Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/compiler/access-builder.cc
diff --git a/src/compiler/access-builder.cc b/src/compiler/access-builder.cc
index 1ca63dfdbbd1f40476e87357a0be0a77cb3fc471..a45b73ec5f926d7eeca8cbf65f05f082f13df8e3 100644
--- a/src/compiler/access-builder.cc
+++ b/src/compiler/access-builder.cc
@@ -571,6 +571,59 @@ FieldAccess AccessBuilder::ForJSGlobalObjectNativeContext() {
}
// static
+FieldAccess AccessBuilder::ForJSArrayIteratorObject() {
+ FieldAccess access = {kTaggedBase,
+ JSArrayIterator::kIteratedObjectOffset,
+ Handle<Name>(),
+ Type::ReceiverOrUndefined(),
+ MachineType::TaggedPointer(),
+ kPointerWriteBarrier};
+ return access;
+}
+
+// static
+FieldAccess AccessBuilder::ForJSArrayIteratorIndex(InstanceType instance_type,
+ ElementsKind elements_kind) {
+ // In generic case, cap to 2^53-1 (per ToLength() in spec) via
+ // kPositiveSafeInteger
+ FieldAccess access = {kTaggedBase,
+ JSArrayIterator::kNextIndexOffset,
+ Handle<Name>(),
+ TypeCache::Get().kPositiveSafeInteger,
+ MachineType::AnyTagged(),
+ kFullWriteBarrier};
+ if (instance_type == JS_ARRAY_TYPE) {
+ if (IsFastDoubleElementsKind(elements_kind)) {
+ access.type = TypeCache::Get().kFixedDoubleArrayLengthType;
+ access.machine_type = MachineType::TaggedSigned();
+ access.write_barrier_kind = kNoWriteBarrier;
+ } else if (IsFastElementsKind(elements_kind)) {
+ access.type = TypeCache::Get().kFixedArrayLengthType;
+ access.machine_type = MachineType::TaggedSigned();
+ access.write_barrier_kind = kNoWriteBarrier;
+ } else {
+ access.type = TypeCache::Get().kJSArrayLengthType;
+ }
+ } else if (instance_type == JS_TYPED_ARRAY_TYPE) {
+ access.type = TypeCache::Get().kJSTypedArrayLengthType;
+ access.machine_type = MachineType::TaggedSigned();
+ access.write_barrier_kind = kNoWriteBarrier;
+ }
+ return access;
+}
+
+// static
+FieldAccess AccessBuilder::ForJSArrayIteratorObjectMap() {
+ FieldAccess access = {kTaggedBase,
+ JSArrayIterator::kIteratedObjectMapOffset,
+ Handle<Name>(),
+ Type::OtherInternal(),
+ MachineType::TaggedPointer(),
+ kPointerWriteBarrier};
+ return access;
+}
+
+// static
FieldAccess AccessBuilder::ForJSStringIteratorString() {
FieldAccess access = {
kTaggedBase, JSStringIterator::kStringOffset, Handle<Name>(),

Powered by Google App Engine
This is Rietveld 408576698