Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(639)

Side by Side Diff: src/compiler/verifier.cc

Issue 2484003002: [builtins] implement JSBuiltinReducer for ArrayIteratorNext() (Closed)
Patch Set: add (some) test coverage, and fix some bugs found by it Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/verifier.h" 5 #include "src/compiler/verifier.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <deque> 8 #include <deque>
9 #include <queue> 9 #include <queue>
10 #include <sstream> 10 #include <sstream>
(...skipping 566 matching lines...) Expand 10 before | Expand all | Expand 10 after
577 CheckTypeIs(node, Type::OtherObject()); 577 CheckTypeIs(node, Type::OtherObject());
578 break; 578 break;
579 case IrOpcode::kJSCreateClosure: 579 case IrOpcode::kJSCreateClosure:
580 // Type is Function. 580 // Type is Function.
581 CheckTypeIs(node, Type::Function()); 581 CheckTypeIs(node, Type::Function());
582 break; 582 break;
583 case IrOpcode::kJSCreateIterResultObject: 583 case IrOpcode::kJSCreateIterResultObject:
584 // Type is OtherObject. 584 // Type is OtherObject.
585 CheckTypeIs(node, Type::OtherObject()); 585 CheckTypeIs(node, Type::OtherObject());
586 break; 586 break;
587 case IrOpcode::kJSCreateKeyValueArray:
588 // Type is OtherObject.
589 CheckTypeIs(node, Type::OtherObject());
590 break;
587 case IrOpcode::kJSCreateLiteralArray: 591 case IrOpcode::kJSCreateLiteralArray:
588 case IrOpcode::kJSCreateLiteralObject: 592 case IrOpcode::kJSCreateLiteralObject:
589 case IrOpcode::kJSCreateLiteralRegExp: 593 case IrOpcode::kJSCreateLiteralRegExp:
590 // Type is OtherObject. 594 // Type is OtherObject.
591 CheckTypeIs(node, Type::OtherObject()); 595 CheckTypeIs(node, Type::OtherObject());
592 break; 596 break;
593 case IrOpcode::kJSLoadProperty: 597 case IrOpcode::kJSLoadProperty:
594 case IrOpcode::kJSLoadNamed: 598 case IrOpcode::kJSLoadNamed:
595 case IrOpcode::kJSLoadGlobal: 599 case IrOpcode::kJSLoadGlobal:
596 // Type can be anything. 600 // Type can be anything.
(...skipping 1032 matching lines...) Expand 10 before | Expand all | Expand 10 after
1629 replacement->op()->EffectOutputCount() > 0); 1633 replacement->op()->EffectOutputCount() > 0);
1630 DCHECK(!NodeProperties::IsFrameStateEdge(edge) || 1634 DCHECK(!NodeProperties::IsFrameStateEdge(edge) ||
1631 replacement->opcode() == IrOpcode::kFrameState); 1635 replacement->opcode() == IrOpcode::kFrameState);
1632 } 1636 }
1633 1637
1634 #endif // DEBUG 1638 #endif // DEBUG
1635 1639
1636 } // namespace compiler 1640 } // namespace compiler
1637 } // namespace internal 1641 } // namespace internal
1638 } // namespace v8 1642 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/types.h ('k') | src/globals.h » ('j') | test/mjsunit/es6/array-iterator-turbo.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698