Add report_id to ErrorReporter interface.

Add report_id to ErrorReporter interface.

This is the follow up CL to https://crrev.com/2476073002

BUG=554323
Committed: https://crrev.com/df30c1872d899957659f5422930a3ad4a5585d91
Cr-Commit-Position: refs/heads/master@{#432240}

[meacer, 2016-11-07 22:42:00]

meacer@chromium.org changed reviewers:
+ estark@chromium.org

[meacer, 2016-11-07 22:42:01]

estark: PTAL?

[estark, 2016-11-11 01:15:49]

lgtm mod request for a test (inline) and assuming the API discussion on the
previous CL resolves on the current API

https://codereview.chromium.org/2483993002/diff/1/components/certificate_repo...
File components/certificate_reporting/error_reporter.h (right):

https://codereview.chromium.org/2483993002/diff/1/components/certificate_repo...
components/certificate_reporting/error_reporter.h:77: void
SetSuccessCallback(const base::Callback<void(int)>& callback);
nit: blank line before

https://codereview.chromium.org/2483993002/diff/1/components/certificate_repo...
File components/certificate_reporting/error_reporter_unittest.cc (right):

https://codereview.chromium.org/2483993002/diff/1/components/certificate_repo...
components/certificate_reporting/error_reporter_unittest.cc:180: 
Could you add a test that the success/error callbacks get called with the
correct report id?

[meacer, 2016-11-11 19:59:29]

https://codereview.chromium.org/2483993002/diff/1/components/certificate_repo...
File components/certificate_reporting/error_reporter.h (right):

https://codereview.chromium.org/2483993002/diff/1/components/certificate_repo...
components/certificate_reporting/error_reporter.h:77: void
SetSuccessCallback(const base::Callback<void(int)>& callback);
On 2016/11/11 01:15:49, estark (slow thru Nov 18) wrote:
> nit: blank line before

Done.

https://codereview.chromium.org/2483993002/diff/1/components/certificate_repo...
File components/certificate_reporting/error_reporter_unittest.cc (right):

https://codereview.chromium.org/2483993002/diff/1/components/certificate_repo...
components/certificate_reporting/error_reporter_unittest.cc:180: 
On 2016/11/11 01:15:49, estark (slow thru Nov 18) wrote:
> Could you add a test that the success/error callbacks get called with the
> correct report id?

Added. I moved the UMA test to ping_manager_unittest.cc since it's recorded by
the ping manager now. Though, it's only temporarily so, as the new
CertificateManagerService will do it later on.

[meacer, 2016-11-11 20:01:13]

meacer@chromium.org changed reviewers:
+ jialiul@chromium.org

[meacer, 2016-11-11 20:01:14]

Jialiu, can you PTAL at chrome/browser/safe_browsing once you are back? Thanks.

[Jialiu Lin, 2016-11-12 15:35:25]

Sorry for the delay. I just got off a cruise ship. I'll review this CL first
thing on Monday morning.

[Jialiu Lin, 2016-11-14 17:20:38]

lgtm for chrome/browser/safe_browsing/*

https://codereview.chromium.org/2483993002/diff/40001/chrome/browser/ssl/cert...
File chrome/browser/ssl/certificate_reporting_test_utils.cc (right):

https://codereview.chromium.org/2483993002/diff/40001/chrome/browser/ssl/cert...
chrome/browser/ssl/certificate_reporting_test_utils.cc:93: int report_id) {
nit: maybe report_id_unused

[meacer, 2016-11-14 23:34:55]

> Sorry for the delay. I just got off a cruise ship. I'll review this CL first
> thing on Monday morning.

Sorry, didn't mean to imply you were late, in fact I had to change the whole CL
chain today so you were early :)

https://codereview.chromium.org/2483993002/diff/40001/chrome/browser/ssl/cert...
File chrome/browser/ssl/certificate_reporting_test_utils.cc (right):

https://codereview.chromium.org/2483993002/diff/40001/chrome/browser/ssl/cert...
chrome/browser/ssl/certificate_reporting_test_utils.cc:93: int report_id) {
On 2016/11/14 17:20:38, Jialiu Lin wrote:
> nit: maybe report_id_unused

I've changed the interface to not accept a report_id, so this is removed now.

[meacer, 2016-11-15 18:31:42]

The CQ bit was checked by meacer@chromium.org

[meacer, 2016-11-15 18:31:43]

The patchset sent to the CQ was uploaded after l-g-t-m from estark@chromium.org,
jialiul@chromium.org
Link to the patchset: https://codereview.chromium.org/2483993002/#ps80001
(title: "Rebase")

[commit-bot: I haz the power, 2016-11-15 18:33:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 20:02:58]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-11-15 20:20:32]

Description was changed from

==========
Add report_id to ErrorReporter interface.

This is the follow up CL to https://crrev.com/2476073002

BUG=554323
==========

to

==========
Add report_id to ErrorReporter interface.

This is the follow up CL to https://crrev.com/2476073002

BUG=554323

Committed: https://crrev.com/df30c1872d899957659f5422930a3ad4a5585d91
Cr-Commit-Position: refs/heads/master@{#432240}
==========

[commit-bot: I haz the power, 2016-11-15 20:20:33]

Patchset 5 (id:??) landed as
https://crrev.com/df30c1872d899957659f5422930a3ad4a5585d91
Cr-Commit-Position: refs/heads/master@{#432240}