Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 2483983002: [Blink] Check thread access in UserGestureIndicator (Closed)

Created:
4 years, 1 month ago by Devlin
Modified:
4 years, 1 month ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Blink] Check thread access in UserGestureIndicator We silently ignore UserGestureIndicators on non-main threads, but tried checking equality against s_rootToken before checking the thread. Check the thread before token equality. BUG=662710 Committed: https://crrev.com/28da3bf9d966cb3048f4dff0284f2173ecb5c5e7 Cr-Commit-Position: refs/heads/master@{#430450}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M third_party/WebKit/Source/platform/UserGestureIndicator.cpp View 1 chunk +5 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Devlin
haraken@, mind taking a look? This is in response to https://chromium.googlesource.com/chromium/src/+/b1ae4b4c9d29625f4ab07eadbeac10a42262bbf2, which was reviewed by ...
4 years, 1 month ago (2016-11-07 22:57:38 UTC) #4
haraken
LGTM
4 years, 1 month ago (2016-11-07 23:35:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2483983002/1
4 years, 1 month ago (2016-11-08 00:46:07 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-08 00:52:17 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-08 00:57:51 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/28da3bf9d966cb3048f4dff0284f2173ecb5c5e7
Cr-Commit-Position: refs/heads/master@{#430450}

Powered by Google App Engine
This is Rietveld 408576698