Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Unified Diff: tools/clang/plugins/tests/trivial_ctor.h

Issue 2483973003: Treat std::atomic_int as a trivial class member when checking for non-trivial classes. (Closed)
Patch Set: Add a test, and fix a typo. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/clang/plugins/FindBadConstructsConsumer.cpp ('k') | tools/clang/plugins/tests/trivial_ctor.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/clang/plugins/tests/trivial_ctor.h
diff --git a/tools/clang/plugins/tests/trivial_ctor.h b/tools/clang/plugins/tests/trivial_ctor.h
new file mode 100644
index 0000000000000000000000000000000000000000..f6dd4048fd15b10c54af181ffa4c5395365943e7
--- /dev/null
+++ b/tools/clang/plugins/tests/trivial_ctor.h
@@ -0,0 +1,33 @@
+// Copyright (c) 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef TRIVIAL_CTOR_H_
+#define TRIVIAL_CTOR_H_
+
+template<typename T>
+struct atomic {
+/*
+ atomic() noexcept = default;
+ ~atomic() noexcept = default;
+ atomic(const atomic&) = delete;
+ atomic& operator=(const atomic&) = delete;
+ atomic& operator=(const atomic&) volatile = delete;
+
+ constexpr atomic(T i) noexcept : i(i) { }
+*/
+
+ T i;
+};
+
+typedef atomic<int> atomic_int;
+
+struct MySpinLock {
+ MySpinLock();
+ ~MySpinLock();
+ MySpinLock(const MySpinLock&);
+ MySpinLock(MySpinLock&&);
+ atomic_int lock_;
+};
+
+#endif // TRIVIAL_CTOR_H_
« no previous file with comments | « tools/clang/plugins/FindBadConstructsConsumer.cpp ('k') | tools/clang/plugins/tests/trivial_ctor.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698