Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Unified Diff: tools/clang/plugins/FindBadConstructsConsumer.cpp

Issue 2483973003: Treat std::atomic_int as a trivial class member when checking for non-trivial classes. (Closed)
Patch Set: Add a test, and fix a typo. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/clang/plugins/tests/trivial_ctor.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/clang/plugins/FindBadConstructsConsumer.cpp
diff --git a/tools/clang/plugins/FindBadConstructsConsumer.cpp b/tools/clang/plugins/FindBadConstructsConsumer.cpp
index 00d4cb9a2316e42dbffd147d21ce93e418c0b867..3c12e9f50c77668ee862b6d27e778064c39eab45 100644
--- a/tools/clang/plugins/FindBadConstructsConsumer.cpp
+++ b/tools/clang/plugins/FindBadConstructsConsumer.cpp
@@ -653,10 +653,14 @@ void FindBadConstructsConsumer::CountType(const Type* type,
// HACK: I'm at a loss about how to get the syntax checker to get
// whether a template is externed or not. For the first pass here,
- // just do retarded string comparisons.
+ // just do simple string comparisons.
+ //
+ // The check for "atomic_int" is a quick hack; The real fix will be to
+ // check the class after template instantiation. TODO(dcheng): Do the real
+ // fix. https://bugs.chromium.org/p/chromium/issues/detail?id=663463
if (TemplateDecl* decl = name.getAsTemplateDecl()) {
std::string base_name = decl->getNameAsString();
- if (base_name == "basic_string")
+ if (base_name == "basic_string" || base_name == "atomic_int")
whitelisted_template = true;
}
« no previous file with comments | « no previous file | tools/clang/plugins/tests/trivial_ctor.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698