Treat std::atomic_int as a trivial class member when checking for non-trivial classes.

Treat atomic_int as a trivial class member when checking for non-trivial classes.

This is a quick hack to unblock work on
https://codereview.chromium.org/2484803003. The real fix will be to check the
class after template instantiation.

BUG=663463
Committed: https://crrev.com/9d17488d4ed2bfecab3d6e723881e1d9cedfb90a
Cr-Commit-Position: refs/heads/master@{#430773}

[palmer, 2016-11-08 20:27:30]

palmer@chromium.org changed reviewers:
+ dcheng@chromium.org, erg@chromium.org

[palmer, 2016-11-08 20:28:21]

A trivial review for a quick hack to unblock other work. I'll re-assign the bug
to dcheng after this, but keep an eye on it so I can learn this stuff.

[Elliot Glaysher, 2016-11-08 20:47:31]

lgtm

(You might want to mention that this is in std:: in the commit message; I didn't
immediately get that from the patch itself.)

[dcheng, 2016-11-08 21:06:20]

LGTM, but let's add a test for this in the plugin tests.

https://codereview.chromium.org/2483973003/diff/1/tools/clang/plugins/FindBad...
File tools/clang/plugins/FindBadConstructsConsumer.cpp (right):

https://codereview.chromium.org/2483973003/diff/1/tools/clang/plugins/FindBad...
tools/clang/plugins/FindBadConstructsConsumer.cpp:659: // check the class after
template instantiation. TODO(dcheng): Do the real
=P

[dcheng, 2016-11-08 21:06:45]

On 2016/11/08 21:06:20, dcheng wrote:
> LGTM, but let's add a test for this in the plugin tests.
> 
>
https://codereview.chromium.org/2483973003/diff/1/tools/clang/plugins/FindBad...
> File tools/clang/plugins/FindBadConstructsConsumer.cpp (right):
> 
>
https://codereview.chromium.org/2483973003/diff/1/tools/clang/plugins/FindBad...
> tools/clang/plugins/FindBadConstructsConsumer.cpp:659: // check the class
after
> template instantiation. TODO(dcheng): Do the real
> =P

(Oh, and the plugin tests don't usually depend on other stuff, so you might need
to duplicate enough of std::atomic's definition to make this happy)

[palmer, 2016-11-08 21:31:36]

> (You might want to mention that this is in std:: in the commit message; I
didn't immediately get that from the patch itself.)

Done.

[palmer, 2016-11-08 23:41:08]

> LGTM, but let's add a test for this in the plugin tests.

Done.

> tools/clang/plugins/FindBadConstructsConsumer.cpp:659: // check the class
after template instantiation. TODO(dcheng): Do the real
> =P

:)

[palmer, 2016-11-08 23:41:11]

The CQ bit was checked by palmer@chromium.org

[palmer, 2016-11-08 23:41:12]

The patchset sent to the CQ was uploaded after l-g-t-m from erg@chromium.org,
dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2483973003/#ps20001
(title: "Add a test, and fix a typo.")

[commit-bot: I haz the power, 2016-11-08 23:41:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-08 23:55:34]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-08 23:58:27]

Description was changed from

==========
Treat atomic_int as a trivial class member when checking for non-trivial
classes.

This is a quick hack to unblock work on
https://codereview.chromium.org/2484803003. The real fix will be to check the
class after template instantiation.

BUG=663463
==========

to

==========
Treat atomic_int as a trivial class member when checking for non-trivial
classes.

This is a quick hack to unblock work on
https://codereview.chromium.org/2484803003. The real fix will be to check the
class after template instantiation.

BUG=663463

Committed: https://crrev.com/9d17488d4ed2bfecab3d6e723881e1d9cedfb90a
Cr-Commit-Position: refs/heads/master@{#430773}
==========

[commit-bot: I haz the power, 2016-11-08 23:58:30]

Patchset 2 (id:??) landed as
https://crrev.com/9d17488d4ed2bfecab3d6e723881e1d9cedfb90a
Cr-Commit-Position: refs/heads/master@{#430773}

[Nico, 2016-11-09 15:05:00]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2491523002/ by thakis@chromium.org.

The reason for reverting is: This broke all clang tot bots, e.g. here: 

https://build.chromium.org/p/chromium.fyi/builders/ClangToTLinux%20%28dbg%29/...

Testing trivial_ctor.cpp... failed: no expected file found
...
Ran 18 tests: 17 succeeded, 1 failed
    trivial_ctor.