Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Issue 2483953002: Separate forced subtree invalidation reasons for location change and SVG resource change (Closed)

Created:
4 years, 1 month ago by Xianzhu
Modified:
4 years, 1 month ago
Reviewers:
pdr.
CC:
blink-reviews, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Separate forced subtree invalidation reasons for location change and SVG resource change This has several purposes: - To reduce layout test result differences between normal path and SlimmingPaintInvalidation which will add paint offset change detection soon. - To avoid unnecessary invalidation of SVG display item clients when an non-SVG/SVG-root ancestor changed location. Previously we conservatively assumed paint offsets of all descendants changed if an ancestor is set forcedSubtreeInvalidationCheckion when the ancestor's location changed, but normal SVG object always have zero paint offsets which won't change. - For SlimmingPaintInvalidation to explicitly invalidate display item clients on ancestor SVG resource change. Previously this logic was shadowed by the convervative paint offset change logic. BUG=660195 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/2902b7fc2999ea4c1f3f647be6f3029ee7e3e168 Cr-Commit-Position: refs/heads/master@{#430453}

Patch Set 1 #

Patch Set 2 : Rebaseline on Linux #

Patch Set 3 : rebaseline-cl #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -493 lines) Patch
M third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=SlimmingPaintInvalidation/paint/invalidation/svg/paintorder-filtered-expected.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=SlimmingPaintInvalidation/paint/invalidation/svg/relative-sized-content-with-resources-expected.txt View 1 2 1 chunk +0 lines, -16 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/svg/absolute-sized-content-with-resources-expected.txt View 1 2 1 chunk +0 lines, -20 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/svg/filter-child-repaint-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/svg/filter-refresh-expected.txt View 1 12 chunks +12 lines, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/svg/image-with-clip-path-expected.txt View 1 2 chunks +0 lines, -16 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/svg/paintorder-filtered-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/svg/relative-sized-content-with-resources-expected.txt View 1 2 1 chunk +0 lines, -16 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/svg/relative-sized-deep-shadow-tree-content-expected.txt View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/svg/relative-sized-shadow-tree-content-expected.txt View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/svg/relative-sized-shadow-tree-content-with-symbol-expected.txt View 1 2 1 chunk +0 lines, -16 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/svg/relative-sized-use-on-symbol-expected.txt View 1 2 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/svg/relative-sized-use-without-attributes-on-symbol-expected.txt View 1 2 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/svg/resource-client-removal-expected.txt View 1 5 chunks +0 lines, -20 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/svg/text-pattern-update-2-expected.txt View 1 1 chunk +8 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/svg/text-pattern-update-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/svg/tspan-pattern-update-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/svg/use-setAttribute-crash-expected.txt View 1 2 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/svg/absolute-sized-content-with-resources-expected.txt View 1 1 chunk +0 lines, -20 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/svg/inner-svg-change-viewPort-relative-expected.txt View 1 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/svg/relative-sized-content-with-resources-expected.txt View 1 1 chunk +0 lines, -16 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/svg/relative-sized-deep-shadow-tree-content-expected.txt View 1 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/svg/relative-sized-shadow-tree-content-expected.txt View 1 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/svg/relative-sized-shadow-tree-content-with-symbol-expected.txt View 1 1 chunk +0 lines, -16 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/svg/relative-sized-use-on-symbol-expected.txt View 1 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/svg/relative-sized-use-without-attributes-on-symbol-expected.txt View 1 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/svg/text-rescale-expected.txt View 1 4 chunks +0 lines, -68 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/svg/text-viewbox-rescale-expected.txt View 1 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/svg/use-setAttribute-crash-expected.txt View 1 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/svg/inner-svg-change-viewPort-relative-expected.txt View 1 2 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/svg/text-rescale-expected.txt View 1 2 4 chunks +0 lines, -68 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/svg/text-viewbox-rescale-expected.txt View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/paint/invalidation/svg/inner-svg-change-viewPort-relative-expected.txt View 1 2 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/paint/invalidation/svg/text-rescale-expected.txt View 1 2 4 chunks +0 lines, -68 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/paint/invalidation/svg/text-viewbox-rescale-expected.txt View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/PaintInvalidationState.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/ObjectPaintInvalidator.cpp View 1 chunk +11 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintInvalidator.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/PaintInvalidator.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (11 generated)
Xianzhu
4 years, 1 month ago (2016-11-07 20:28:22 UTC) #4
pdr.
LGTM
4 years, 1 month ago (2016-11-07 21:30:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2483953002/40001
4 years, 1 month ago (2016-11-07 23:30:49 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-08 01:05:43 UTC) #14
commit-bot: I haz the power
4 years, 1 month ago (2016-11-08 01:17:23 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/2902b7fc2999ea4c1f3f647be6f3029ee7e3e168
Cr-Commit-Position: refs/heads/master@{#430453}

Powered by Google App Engine
This is Rietveld 408576698