Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4271)

Unified Diff: blimp/engine/session/page_load_tracker.h

Issue 2483933003: blimp: Fix page load status tracking. (Closed)
Patch Set: cancelable callback Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | blimp/engine/session/page_load_tracker.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: blimp/engine/session/page_load_tracker.h
diff --git a/blimp/engine/session/page_load_tracker.h b/blimp/engine/session/page_load_tracker.h
index 2a1d02c218af57bf587c1ca8e7cdbc6195057be3..55d509a0d8b5a48c0aefa358a51f726eeaaf5c85 100644
--- a/blimp/engine/session/page_load_tracker.h
+++ b/blimp/engine/session/page_load_tracker.h
@@ -5,7 +5,7 @@
#ifndef BLIMP_ENGINE_SESSION_PAGE_LOAD_TRACKER_H_
#define BLIMP_ENGINE_SESSION_PAGE_LOAD_TRACKER_H_
-#include "base/containers/small_map.h"
+#include "base/cancelable_callback.h"
#include "base/macros.h"
#include "content/public/browser/render_frame_host.h"
#include "content/public/browser/render_widget_host.h"
@@ -37,39 +37,17 @@ class PageLoadTracker : public content::WebContentsObserver {
~PageLoadTracker() override;
private:
- struct LoadStatus {
- // Set to true on receiving a notification from the renderer that the load
- // finished. See WebContentsObserver::DidFinishLoad.
- bool page_loaded = false;
-
- // Set to true on receiving a notification from the renderer that the first
- // paint after a navigation was performed.
- // See WebContentsObserver::DidFirstPaintAfterLoad.
- bool did_first_paint = false;
-
- bool Loaded() const;
- };
-
- typedef base::SmallMap<std::map<content::RenderWidgetHost*, LoadStatus>>
- RenderWidgetLoadStatusMap;
-
// content::WebContentsObserver implementation.
- void DidStartProvisionalLoadForFrame(
- content::RenderFrameHost* render_frame_host,
- const GURL& validated_url,
- bool is_error_page,
- bool is_iframe_srcdoc) override;
- void DidFinishLoad(content::RenderFrameHost* render_frame_host,
- const GURL& validated_url) override;
- void DidFailLoad(content::RenderFrameHost* render_frame_host,
- const GURL& validated_url,
- int error_code,
- const base::string16& error_description,
- bool was_ignored_by_handler) override;
- void DidFirstPaintAfterLoad(
- content::RenderWidgetHost* render_widget_host) override;
+ void DidStartNavigation(
+ content::NavigationHandle* navigation_handle) override;
+ void DidFinishNavigation(
+ content::NavigationHandle* navigation_handle) override;
+
+ // Invoked when the renderer has performed at least one paint after the
+ // navigation was committed.
+ void DidPaintAfterNavigationCommitted(bool result);
- RenderWidgetLoadStatusMap render_widget_load_status_;
+ base::CancelableCallback<void(bool)> did_paint_after_navigation_callback_;
PageLoadTrackerClient* client_;
« no previous file with comments | « no previous file | blimp/engine/session/page_load_tracker.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698