Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 2483843002: Revert of [scheduler] Teach scheduler about audio state (Closed)

Created:
4 years, 1 month ago by magjed_chromium
Modified:
4 years, 1 month ago
Reviewers:
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [scheduler] Teach scheduler about audio state (patchset #11 id:200001 of https://codereview.chromium.org/2383473002/ ) Reason for revert: This CL breaks chromium.webrtc browser_tests on all platforms with the following failure: 5 tests timed out: WebRtcPerfBrowserTest.MANUAL_RunsAudioVideoCall60SecsAndLogsInternalMetricsH264 (../../chrome/browser/media/webrtc/webrtc_perf_browsertest.cc:242) WebRtcPerfBrowserTest.MANUAL_RunsAudioVideoCall60SecsAndLogsInternalMetricsVp8 (../../chrome/browser/media/webrtc/webrtc_perf_browsertest.cc:228) WebRtcPerfBrowserTest.MANUAL_RunsAudioVideoCall60SecsAndLogsInternalMetricsVp9 (../../chrome/browser/media/webrtc/webrtc_perf_browsertest.cc:234) WebRtcPerfBrowserTest.MANUAL_RunsOneWayCall60SecsAndLogsInternalMetricsDefault (../../chrome/browser/media/webrtc/webrtc_perf_browsertest.cc:257) WebRtcPerfBrowserTest.MANUAL_RunsOneWayCall60SecsAndLogsInternalMetricsWithOpusDtx (../../chrome/browser/media/webrtc/webrtc_perf_browsertest.cc:263) See for example https://build.chromium.org/p/chromium.webrtc/builders/Linux%20Tester/builds/23777. Original issue's description: > [scheduler] Teach scheduler about audio state > > This patch wires information about audio state to renderer scheduler > and stops all throttling (background and offscreen) while > audio is playing and for a short period after audio is stopped. > > BUG=642321, 616519, 656019 > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel > > Committed: https://crrev.com/a7a651d546b76499821b4ba47b8f017d4b8becac > Committed: https://crrev.com/d8bd26c6124f76be5a0c7cfacc39c3996dd29adf > Cr-Original-Commit-Position: refs/heads/master@{#423405} > Cr-Commit-Position: refs/heads/master@{#429861} TBR=alexclarke@chromium.org,clamy@chromium.org,dcheng@chromium.org,skyostil@chromium.org,dalecurtis@chromium.org,altimin@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=642321, 616519, 656019 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -245 lines) Patch
M cc/test/ordered_simple_task_runner.cc View 1 1 chunk +1 line, -3 lines 0 comments Download
M content/browser/media/audio_stream_monitor.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 2 chunks +2 lines, -9 lines 0 comments Download
M content/common/page_messages.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M content/public/browser/web_contents.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M content/renderer/render_view_impl.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/render_view_impl.cc View 1 2 chunks +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.h View 1 6 chunks +1 line, -13 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc View 1 8 chunks +2 lines, -77 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler.h View 1 2 chunks +4 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler.cc View 1 10 chunks +45 lines, -61 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler_unittest.cc View 1 1 chunk +0 lines, -39 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl.h View 1 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl.cc View 1 2 chunks +0 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.cpp View 1 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/public/platform/WebViewScheduler.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/public/web/WebView.h View 1 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
magjed_chromium
Created Revert of [scheduler] Teach scheduler about audio state
4 years, 1 month ago (2016-11-07 14:58:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2483843002/1
4 years, 1 month ago (2016-11-07 14:58:29 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/300916) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 1 month ago (2016-11-07 15:01:16 UTC) #5
altimin
4 years, 1 month ago (2016-11-08 16:15:55 UTC) #7
The underlying issue was fixed, this revert is no longer needed.

Powered by Google App Engine
This is Rietveld 408576698