Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 2483823004: Reland of Clean up some NativeTheme code. (Closed)

Created:
4 years, 1 month ago by Evan Stade
Modified:
4 years, 1 month ago
Reviewers:
bokan, xlai (Olivia), sky
CC:
chromium-reviews, tfarina, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Clean up some NativeTheme code. (patchset #1 id:1 of https://codereview.chromium.org/2484973003/ ) Reason for revert: wrong CL reverted Original issue's description: > Revert of Clean up some NativeTheme code. (patchset #1 id:1 of https://codereview.chromium.org/2485013002/ ) > > Reason for revert: > Apparently CQ landed this CL twice. Tried reverting it once to see what happens. > > Original issue's description: > > Reland of Clean up some NativeTheme code. > > ( https://codereview.chromium.org/2480993002/ ) > > > > Now with appropriate use of break in switch statement. > > > > Original issue's description: > > > Clean up some NativeTheme code. > > > > > > - improve instantiation > > > - allow to specify separate instances for web and native > > > - two NativeThemeAura instances coexist for w/wo overlay scrollbars > > > > > > BUG=307091 > > > > Committed: https://crrev.com/93ed99a0238f25fe391874d3f6dfa02c01acb781 > > Cr-Commit-Position: refs/heads/master@{#430608} > > TBR=bokan@chromium.org,sky@chromium.org,estade@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > > Committed: https://crrev.com/16a00aca0642af4f75ed4c68f662e68f590c6cef > Cr-Commit-Position: refs/heads/master@{#430610} TBR=bokan@chromium.org,sky@chromium.org,xlai@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/fb1357c76c573cb25d22c19123df3795ff45c46f Cr-Commit-Position: refs/heads/master@{#430611}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -42 lines) Patch
M ui/native_theme/native_theme.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/native_theme/native_theme_android.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M ui/native_theme/native_theme_aura.h View 2 chunks +4 lines, -1 line 0 comments Download
M ui/native_theme/native_theme_aura.cc View 6 chunks +44 lines, -32 lines 0 comments Download
M ui/native_theme/native_theme_dark_aura.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/native_theme/native_theme_mac.mm View 1 chunk +5 lines, -0 lines 0 comments Download
M ui/native_theme/native_theme_win.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/views/view.cc View 1 chunk +1 line, -8 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Evan Stade
Created Reland of Clean up some NativeTheme code.
4 years, 1 month ago (2016-11-08 14:56:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2483823004/1
4 years, 1 month ago (2016-11-08 14:57:02 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-08 14:58:07 UTC) #4
commit-bot: I haz the power
4 years, 1 month ago (2016-11-08 15:01:02 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fb1357c76c573cb25d22c19123df3795ff45c46f
Cr-Commit-Position: refs/heads/master@{#430611}

Powered by Google App Engine
This is Rietveld 408576698