Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(657)

Issue 2483793002: Mark WebURLResponse data size getters as ForTesting (Closed)

Created:
4 years, 1 month ago by yhirano
Modified:
4 years, 1 month ago
Reviewers:
kinuko, Adam Rice, esprehn, tzik
CC:
chromium-reviews, blink-reviews, jam, dglazkov+blink, darin-cc_chromium.org, blink-reviews-api_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mark WebURLResponse data size getters as ForTesting The following getters are only used in tests, and I want to delete them eventually. - encodedDataLength - encodedBodyLength - decodedBodyLength BUG=603396 Committed: https://crrev.com/3ed22b610c31300b8c2746e1beb214a571d9f61b Cr-Commit-Position: refs/heads/master@{#432195}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -8 lines) Patch
M content/child/web_url_loader_impl_unittest.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/exported/WebURLResponse.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/public/platform/WebURLResponse.h View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
yhirano
4 years, 1 month ago (2016-11-07 06:37:26 UTC) #4
tzik
lgtm
4 years, 1 month ago (2016-11-07 08:48:01 UTC) #7
Adam Rice
lgtm
4 years, 1 month ago (2016-11-09 05:20:43 UTC) #8
yhirano
+esprehn@ for OWNER review.
4 years, 1 month ago (2016-11-09 05:24:04 UTC) #10
kinuko
drive-by LGTM (Having test-only methods at public layer is not too good but they are ...
4 years, 1 month ago (2016-11-11 13:33:17 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2483793002/1
4 years, 1 month ago (2016-11-15 13:42:26 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-15 16:41:06 UTC) #14
commit-bot: I haz the power
4 years, 1 month ago (2016-11-15 16:45:38 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3ed22b610c31300b8c2746e1beb214a571d9f61b
Cr-Commit-Position: refs/heads/master@{#432195}

Powered by Google App Engine
This is Rietveld 408576698