Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 2483783006: [sql] Histogram for mmap status VIEW. (Closed)

Created:
4 years, 1 month ago by Scott Hess - ex-Googler
Modified:
4 years, 1 month ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[sql] Histogram for mmap status VIEW. https://codereview.chromium.org/2397753005/ landed a change to how sql::Connection handles mmap tracking. I neglected to add the histograms.xml entry to mirror an enum change. BUG=652359 Committed: https://crrev.com/e28e2e598746a19c53447f8d54c1927aba6e5b59 Cr-Commit-Position: refs/heads/master@{#431143}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M tools/metrics/histograms/histograms.xml View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Scott Hess - ex-Googler
4 years, 1 month ago (2016-11-09 23:27:52 UTC) #2
Ilya Sherman
lgtm
4 years, 1 month ago (2016-11-10 00:18:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2483783006/1
4 years, 1 month ago (2016-11-10 00:19:41 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-10 02:13:47 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-11-10 02:16:42 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e28e2e598746a19c53447f8d54c1927aba6e5b59
Cr-Commit-Position: refs/heads/master@{#431143}

Powered by Google App Engine
This is Rietveld 408576698