Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Issue 2483783005: bluetooth: bluez: Implement RetrieveGattConnectedDevicesWithDiscoveryFilter (Closed)

Created:
4 years, 1 month ago by ortuno
Modified:
4 years, 1 month ago
Reviewers:
scheib
CC:
chromium-reviews, ortuno+watch_chromium.org, scheib+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bluetooth: bluez: Implement RetrieveGattConnectedDevicesWithDiscoveryFilter BUG=653032 Committed: https://crrev.com/c41bb7c70268671202cf42b8b3ffabbb993a5271 Cr-Commit-Position: refs/heads/master@{#431138}

Patch Set 1 #

Patch Set 2 : Clean up #

Unified diffs Side-by-side diffs Delta from patch set Stats (+196 lines, -4 lines) Patch
M device/bluetooth/bluez/bluetooth_adapter_bluez.h View 2 chunks +4 lines, -0 lines 0 comments Download
M device/bluetooth/bluez/bluetooth_adapter_bluez.cc View 2 chunks +30 lines, -0 lines 0 comments Download
M device/bluetooth/bluez/bluetooth_gatt_bluez_unittest.cc View 1 5 chunks +138 lines, -0 lines 0 comments Download
M device/bluetooth/dbus/fake_bluetooth_device_client.h View 1 chunk +4 lines, -0 lines 0 comments Download
M device/bluetooth/dbus/fake_bluetooth_device_client.cc View 2 chunks +16 lines, -4 lines 0 comments Download
M device/bluetooth/dbus/fake_bluetooth_gatt_service_client.h View 1 chunk +2 lines, -0 lines 0 comments Download
M device/bluetooth/dbus/fake_bluetooth_gatt_service_client.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (14 generated)
ortuno
scheib: PTAL
4 years, 1 month ago (2016-11-09 21:24:08 UTC) #7
scheib
LGTM, I updated the title to include 'bluez'.
4 years, 1 month ago (2016-11-10 00:27:40 UTC) #13
ortuno
Thanks!
4 years, 1 month ago (2016-11-10 01:56:55 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2483783005/20001
4 years, 1 month ago (2016-11-10 01:57:13 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-10 02:01:53 UTC) #18
commit-bot: I haz the power
4 years, 1 month ago (2016-11-10 02:05:15 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c41bb7c70268671202cf42b8b3ffabbb993a5271
Cr-Commit-Position: refs/heads/master@{#431138}

Powered by Google App Engine
This is Rietveld 408576698