fix #27771, create directory if needed

fix #27771, create directory if needed

R=vsm@google.com

Committed: https://github.com/dart-lang/dev_compiler/commit/8f04f902dfdd79592fa3fb4d7264cf596cb817ac

[Jennifer Messerly, 2016-11-08 02:17:55]

jmesserly@google.com changed reviewers:
+ vsm@google.com

[kevmoo, 2016-11-08 02:51:29]

kevmoo@google.com changed reviewers:
+ kevmoo@google.com

[kevmoo, 2016-11-08 02:51:30]

DBC

https://codereview.chromium.org/2483753004/diff/1/pkg/dev_compiler/test/worke...
File pkg/dev_compiler/test/worker/worker_test.dart (right):

https://codereview.chromium.org/2483753004/diff/1/pkg/dev_compiler/test/worke...
pkg/dev_compiler/test/worker/worker_test.dart:40:
outputJsFile.parent.deleteSync(recursive: true);
Huh? This seems – bad.

Are we sure this directory is empty?

[Jennifer Messerly, 2016-11-08 18:11:51]

https://codereview.chromium.org/2483753004/diff/1/pkg/dev_compiler/test/worke...
File pkg/dev_compiler/test/worker/worker_test.dart (right):

https://codereview.chromium.org/2483753004/diff/1/pkg/dev_compiler/test/worke...
pkg/dev_compiler/test/worker/worker_test.dart:40:
outputJsFile.parent.deleteSync(recursive: true);
On 2016/11/08 02:51:30, kevmoo wrote:
> Huh? This seems – bad.
> 
> Are we sure this directory is empty?

it's a test folder, so yes (we're in "worker_test.dart"). I'm happy to make it
more defensive somehow, if you have suggestions.

[kevmoo, 2016-11-08 18:16:47]

Oops...

https://codereview.chromium.org/2483753004/diff/1/pkg/dev_compiler/test/worke...
File pkg/dev_compiler/test/worker/worker_test.dart (right):

https://codereview.chromium.org/2483753004/diff/1/pkg/dev_compiler/test/worke...
pkg/dev_compiler/test/worker/worker_test.dart:40:
outputJsFile.parent.deleteSync(recursive: true);
On 2016/11/08 18:11:51, Jennifer Messerly wrote:
> On 2016/11/08 02:51:30, kevmoo wrote:
> > Huh? This seems – bad.
> > 
> > Are we sure this directory is empty?
> 
> it's a test folder, so yes (we're in "worker_test.dart"). I'm happy to make it
> more defensive somehow, if you have suggestions.

*sigh* Sorry. Paranoid. :-)

[vsm, 2016-11-08 18:18:11]

lgtm

[Jennifer Messerly, 2016-11-08 18:21:24]

Description was changed from

==========
fix #27771, create directory if needed
==========

to

==========
fix #27771, create directory if needed

R=vsm@google.com

Committed:
https://github.com/dart-lang/dev_compiler/commit/8f04f902dfdd79592fa3fb4d7264...
==========

[Jennifer Messerly, 2016-11-08 18:21:27]

Committed patchset #1 (id:1) manually as
8f04f902dfdd79592fa3fb4d7264cf596cb817ac (presubmit successful).