Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Issue 2483753003: views examples: remove obsolete CTA button example (Closed)

Created:
4 years, 1 month ago by Elly Fong-Jones
Modified:
4 years, 1 month ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

views examples: remove obsolete CTA button example CTA buttons are gone now and default is an alias for prominent. BUG=660142 Committed: https://crrev.com/2267565831e4e2fb9d5931bce7cb701231a93513 Cr-Commit-Position: refs/heads/master@{#430709}

Patch Set 1 #

Total comments: 1

Patch Set 2 : remove md_prominent_button_ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -13 lines) Patch
M ui/views/examples/button_example.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/examples/button_example.cc View 1 2 chunks +5 lines, -12 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Elly Fong-Jones
sky: ptal? :)
4 years, 1 month ago (2016-11-07 14:08:19 UTC) #3
sky
LGTM https://codereview.chromium.org/2483753003/diff/1/ui/views/examples/button_example.cc File ui/views/examples/button_example.cc (left): https://codereview.chromium.org/2483753003/diff/1/ui/views/examples/button_example.cc#oldcode71 ui/views/examples/button_example.cc:71: md_prominent_button_ = Remove field too.
4 years, 1 month ago (2016-11-07 17:03:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2483753003/20001
4 years, 1 month ago (2016-11-08 20:32:57 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-08 20:57:46 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-08 21:01:17 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2267565831e4e2fb9d5931bce7cb701231a93513
Cr-Commit-Position: refs/heads/master@{#430709}

Powered by Google App Engine
This is Rietveld 408576698