Add referrerpolicy support to link prefetch

Add referrerpolicy support to link prefetch

This CL adds referrerpolicy support to <link rel=prefetch>. It also
refactors and removes no-longer-relevant TODOs from related code.

Another functional change is making it so that dns-prefetch and
preconnect relations no longer work unless the node is added to the
document.

BUG=595099
Committed: https://crrev.com/970f4a4b5393b71d1bb37bdba7f82c2e515c5c62
Cr-Commit-Position: refs/heads/master@{#430588}

[Yoav Weiss, 2016-11-06 16:25:50]

The CQ bit was checked by yoav@yoav.ws to run a CQ dry run

[commit-bot: I haz the power, 2016-11-06 16:25:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yoav Weiss, 2016-11-06 16:27:59]

yoav@yoav.ws changed reviewers:
+ estark@chromium.org, mkwst@chromium.org

[Yoav Weiss, 2016-11-06 16:27:59]

Hey Emily and Mike! :)

This is continuing the conquest of getting referrerpolicy support on
HTMLLinkElement. Care to take a look?

[commit-bot: I haz the power, 2016-11-06 17:27:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-06 17:27:06]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Mike West, 2016-11-07 09:52:43]

LGTM % optional nit. Thanks!

https://codereview.chromium.org/2483713002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/loader/LinkLoader.cpp (right):

https://codereview.chromium.org/2483713002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/LinkLoader.cpp:351: ResourceRequest
resourceRequest(document.completeURL(href));
You could avoid creating this intermediate object by constructing
`linkRequest(document.completeURL(href), ...)` and then manipulating
`linkRequest.mutableResourceRequest()`. *shrug* Up to you, but that seems
simpler to me.

[Yoav Weiss, 2016-11-08 09:23:54]

https://codereview.chromium.org/2483713002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/loader/LinkLoader.cpp (right):

https://codereview.chromium.org/2483713002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/LinkLoader.cpp:351: ResourceRequest
resourceRequest(document.completeURL(href));
On 2016/11/07 09:52:43, Mike West wrote:
> You could avoid creating this intermediate object by constructing
> `linkRequest(document.completeURL(href), ...)` and then manipulating
> `linkRequest.mutableResourceRequest()`. *shrug* Up to you, but that seems
> simpler to me.

Yeah, slightly simpler I guess. Changed

[Yoav Weiss, 2016-11-08 09:25:02]

The CQ bit was checked by yoav@yoav.ws to run a CQ dry run

[commit-bot: I haz the power, 2016-11-08 09:25:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yoav Weiss, 2016-11-08 09:27:22]

Mike - can you also take a look at the DCHECK I added? (Added it because of a
suspected crash that turned out to be nothing. I can split it to a separate CL
if that's better)

https://codereview.chromium.org/2483713002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/loader/LinkLoader.cpp (right):

https://codereview.chromium.org/2483713002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/LinkLoader.cpp:79: DCHECK(m_client);
Added a DCHECK here that seemed missing...

[commit-bot: I haz the power, 2016-11-08 11:00:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-08 11:00:09]

Dry run: This issue passed the CQ dry run.

[Mike West, 2016-11-08 11:34:04]

Sure. Still LGTM.

[Yoav Weiss, 2016-11-08 12:15:28]

The CQ bit was checked by yoav@yoav.ws

[commit-bot: I haz the power, 2016-11-08 12:15:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-08 12:20:44]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-08 12:23:24]

Description was changed from

==========
Add referrerpolicy support to link prefetch

This CL adds referrerpolicy support to <link rel=prefetch>. It also
refactors and removes no-longer-relevant TODOs from related code.

Another functional change is making it so that dns-prefetch and
preconnect relations no longer work unless the node is added to the
document.

BUG=595099
==========

to

==========
Add referrerpolicy support to link prefetch

This CL adds referrerpolicy support to <link rel=prefetch>. It also
refactors and removes no-longer-relevant TODOs from related code.

Another functional change is making it so that dns-prefetch and
preconnect relations no longer work unless the node is added to the
document.

BUG=595099

Committed: https://crrev.com/970f4a4b5393b71d1bb37bdba7f82c2e515c5c62
Cr-Commit-Position: refs/heads/master@{#430588}
==========

[commit-bot: I haz the power, 2016-11-08 12:23:25]

Patchset 3 (id:??) landed as
https://crrev.com/970f4a4b5393b71d1bb37bdba7f82c2e515c5c62
Cr-Commit-Position: refs/heads/master@{#430588}