Replicate feature policy headers to remote frames

third_party/WebKit/Source/platform/feature_policy/FeaturePolicyTest.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "platform/feature_policy/FeaturePolicy.h"
 
 #include "platform/RuntimeEnabledFeatures.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 // Origin strings used for tests
@@ skipping 71 matching lines @@
   // have at least one of each kind of default behaviour represented.
   FeaturePolicy::FeatureList m_featureList;
 };
 
 TEST_F(FeaturePolicyTest, ParseValidPolicy) {
   Vector<String> messages;
   for (const char* policyString : kValidPolicies) {
     messages.clear();
     std::unique_ptr<FeaturePolicy> policy =
         createFromParentPolicy(nullptr, m_originA);
-    policy->setHeaderPolicy(policyString, messages);
+    policy->setHeaderPolicy(policyString, &messages);
     EXPECT_EQ(0UL, messages.size());
   }
 }
 
 TEST_F(FeaturePolicyTest, ParseInvalidPolicy) {
   Vector<String> messages;
   for (const char* policyString : kInvalidPolicies) {
     messages.clear();
     std::unique_ptr<FeaturePolicy> policy =
         createFromParentPolicy(nullptr, m_originA);
-    policy->setHeaderPolicy(policyString, messages);
+    policy->setHeaderPolicy(policyString, &messages);
     EXPECT_NE(0UL, messages.size());
   }
 }
 
 TEST_F(FeaturePolicyTest, TestInitialPolicy) {
   // +-------------+
   // |(1)Origin A  |
   // |No Policy    |
   // +-------------+
   // Default-on and top-level-only features should be enabled in top-level
@@ skipping 54 matching lines @@
   // | |Policy: {"default-self": ["self"]} | |
   // | +-----------------------------------+ |
   // +---------------------------------------+
   // Default-self feature should be disabled in cross origin frame, even if no
   // policy was specified in the parent frame.
   Vector<String> messages;
   std::unique_ptr<FeaturePolicy> policy1 =
       createFromParentPolicy(nullptr, m_originA);
   std::unique_ptr<FeaturePolicy> policy2 =
       createFromParentPolicy(policy1.get(), m_originB);
-  policy2->setHeaderPolicy("{\"default-self\": [\"self\"]}", messages);
+  policy2->setHeaderPolicy("{\"default-self\": [\"self\"]}", &messages);
   EXPECT_EQ(0UL, messages.size());
   EXPECT_FALSE(policy2->isFeatureEnabled(kDefaultSelfFeature));
 }
 
 TEST_F(FeaturePolicyTest, TestFrameSelfInheritance) {
   // +------------------------------------------+
   // |(1) Origin A                              |
   // |Policy: {"default-self": ["self"]}        |
   // | +-----------------+  +-----------------+ |
   // | |(2) Origin A     |  |(4) Origin B     | |
   // | |No Policy        |  |No Policy        | |
   // | | +-------------+ |  | +-------------+ | |
   // | | |(3)Origin A  | |  | |(5)Origin B  | | |
   // | | |No Policy    | |  | |No Policy    | | |
   // | | +-------------+ |  | +-------------+ | |
   // | +-----------------+  +-----------------+ |
   // +------------------------------------------+
   // Feature should be enabled at the top-level, and through the chain of
   // same-origin frames 2 and 3. It should be disabled in frames 4 and 5, as
   // they are at a different origin.
   Vector<String> messages;
   std::unique_ptr<FeaturePolicy> policy1 =
       createFromParentPolicy(nullptr, m_originA);
-  policy1->setHeaderPolicy("{\"default-self\": [\"self\"]}", messages);
+  policy1->setHeaderPolicy("{\"default-self\": [\"self\"]}", &messages);
   EXPECT_EQ(0UL, messages.size());
   std::unique_ptr<FeaturePolicy> policy2 =
       createFromParentPolicy(policy1.get(), m_originA);
   std::unique_ptr<FeaturePolicy> policy3 =
       createFromParentPolicy(policy2.get(), m_originA);
   std::unique_ptr<FeaturePolicy> policy4 =
       createFromParentPolicy(policy1.get(), m_originB);
   std::unique_ptr<FeaturePolicy> policy5 =
       createFromParentPolicy(policy4.get(), m_originB);
   EXPECT_TRUE(policy2->isFeatureEnabled(kDefaultSelfFeature));
@@ skipping 13 matching lines @@
   // | | |(3)Origin A  | |               |
   // | | |No Policy    | |               |
   // | | +-------------+ |               |
   // | +-----------------+               |
   // +-----------------------------------+
   // Feature which is enabled at top-level should be disabled in frame 3, as
   // it is embedded by frame 2, for which the feature is not enabled.
   Vector<String> messages;
   std::unique_ptr<FeaturePolicy> policy1 =
       createFromParentPolicy(nullptr, m_originA);
-  policy1->setHeaderPolicy("{\"default-self\": [\"self\"]}", messages);
+  policy1->setHeaderPolicy("{\"default-self\": [\"self\"]}", &messages);
   EXPECT_EQ(0UL, messages.size());
   std::unique_ptr<FeaturePolicy> policy2 =
       createFromParentPolicy(policy1.get(), m_originB);
   std::unique_ptr<FeaturePolicy> policy3 =
       createFromParentPolicy(policy2.get(), m_originA);
   EXPECT_FALSE(policy2->isFeatureEnabled(kDefaultSelfFeature));
   EXPECT_FALSE(policy3->isFeatureEnabled(kDefaultSelfFeature));
 }
 
 TEST_F(FeaturePolicyTest, TestSelectiveFrameInheritance) {
   // +------------------------------------------+
   // |(1) Origin A                              |
   // |Policy: {"default-self": ["Origin B"]}    |
   // | +-----------------+  +-----------------+ |
   // | |(2) Origin B     |  |(3) Origin C     | |
   // | |No Policy        |  |No Policy        | |
   // | |                 |  | +-------------+ | |
   // | |                 |  | |(4)Origin B  | | |
   // | |                 |  | |No Policy    | | |
   // | |                 |  | +-------------+ | |
   // | +-----------------+  +-----------------+ |
   // +------------------------------------------+
   // Feature should be enabled in second level Origin B frame, but disabled in
   // Frame 4, because it is embedded by frame 3, where the feature is not
   // enabled.
   Vector<String> messages;
   std::unique_ptr<FeaturePolicy> policy1 =
       createFromParentPolicy(nullptr, m_originA);
-  policy1->setHeaderPolicy("{\"default-self\": [\"" ORIGIN_B "\"]}", messages);
+  policy1->setHeaderPolicy("{\"default-self\": [\"" ORIGIN_B "\"]}", &messages);
   EXPECT_EQ(0UL, messages.size());
   std::unique_ptr<FeaturePolicy> policy2 =
       createFromParentPolicy(policy1.get(), m_originB);
   std::unique_ptr<FeaturePolicy> policy3 =
       createFromParentPolicy(policy1.get(), m_originC);
   std::unique_ptr<FeaturePolicy> policy4 =
       createFromParentPolicy(policy3.get(), m_originB);
   EXPECT_TRUE(policy2->isFeatureEnabled(kDefaultSelfFeature));
   EXPECT_FALSE(policy3->isFeatureEnabled(kDefaultSelfFeature));
   EXPECT_FALSE(policy4->isFeatureEnabled(kDefaultSelfFeature));
 }
 
 TEST_F(FeaturePolicyTest, TestPolicyCanBlockSelf) {
   // +----------------------------+
   // |(1)Origin A                 |
   // |Policy: {"default-on": []}  |
   // +----------------------------+
   // Default-on feature should be disabled in top-level frame.
   Vector<String> messages;
   std::unique_ptr<FeaturePolicy> policy1 =
       createFromParentPolicy(nullptr, m_originA);
-  policy1->setHeaderPolicy("{\"default-on\": []}", messages);
+  policy1->setHeaderPolicy("{\"default-on\": []}", &messages);
   EXPECT_EQ(0UL, messages.size());
   EXPECT_FALSE(policy1->isFeatureEnabled(kDefaultOnFeature));
 }
 
 TEST_F(FeaturePolicyTest, TestParentPolicyBlocksSameOriginChildPolicy) {
   // +----------------------------+
   // |(1)Origin A                 |
   // |Policy: {"default-on": []}  |
   // | +-------------+            |
   // | |(2)Origin A  |            |
   // | |No Policy    |            |
   // | +-------------+            |
   // +----------------------------+
   // Feature should be disabled in child frame.
   Vector<String> messages;
   std::unique_ptr<FeaturePolicy> policy1 =
       createFromParentPolicy(nullptr, m_originA);
-  policy1->setHeaderPolicy("{\"default-on\": []}", messages);
+  policy1->setHeaderPolicy("{\"default-on\": []}", &messages);
   EXPECT_EQ(0UL, messages.size());
   std::unique_ptr<FeaturePolicy> policy2 =
       createFromParentPolicy(policy1.get(), m_originA);
   EXPECT_FALSE(policy2->isFeatureEnabled(kDefaultOnFeature));
 }
 
 TEST_F(FeaturePolicyTest, TestChildPolicyCanBlockSelf) {
   // +--------------------------------+
   // |(1)Origin A                     |
   // |No Policy                       |
   // | +----------------------------+ |
   // | |(2)Origin B                 | |
   // | |Policy: {"default-on": []}  | |
   // | +----------------------------+ |
   // +--------------------------------+
   // Default-on feature should be disabled by cross-origin child frame.
   Vector<String> messages;
   std::unique_ptr<FeaturePolicy> policy1 =
       createFromParentPolicy(nullptr, m_originA);
   std::unique_ptr<FeaturePolicy> policy2 =
       createFromParentPolicy(policy1.get(), m_originB);
-  policy2->setHeaderPolicy("{\"default-on\": []}", messages);
+  policy2->setHeaderPolicy("{\"default-on\": []}", &messages);
   EXPECT_EQ(0UL, messages.size());
   EXPECT_FALSE(policy2->isFeatureEnabled(kDefaultOnFeature));
 }
 
 TEST_F(FeaturePolicyTest, TestChildPolicyCanBlockChildren) {
   // +--------------------------------------+
   // |(1)Origin A                           |
   // |No Policy                             |
   // | +----------------------------------+ |
   // | |(2)Origin B                       | |
   // | |Policy: {"default-on": ["self"]}  | |
   // | | +-------------+                  | |
   // | | |(3)Origin C  |                  | |
   // | | |No Policy    |                  | |
   // | | +-------------+                  | |
   // | +----------------------------------+ |
   // +--------------------------------------+
   // Default-on feature should be enabled in frames 1 and 2; disabled in frame
   // 3 by child frame policy.
   Vector<String> messages;
   std::unique_ptr<FeaturePolicy> policy1 =
       createFromParentPolicy(nullptr, m_originA);
   std::unique_ptr<FeaturePolicy> policy2 =
       createFromParentPolicy(policy1.get(), m_originB);
-  policy2->setHeaderPolicy("{\"default-on\": [\"self\"]}", messages);
+  policy2->setHeaderPolicy("{\"default-on\": [\"self\"]}", &messages);
   EXPECT_EQ(0UL, messages.size());
   std::unique_ptr<FeaturePolicy> policy3 =
       createFromParentPolicy(policy2.get(), m_originC);
   EXPECT_TRUE(policy2->isFeatureEnabled(kDefaultOnFeature));
   EXPECT_FALSE(policy3->isFeatureEnabled(kDefaultOnFeature));
 }
 
 TEST_F(FeaturePolicyTest, TestParentPolicyBlocksCrossOriginChildPolicy) {
   // +----------------------------+
   // |(1)Origin A                 |
   // |Policy: {"default-on": []}  |
   // | +-------------+            |
   // | |(2)Origin B  |            |
   // | |No Policy    |            |
   // | +-------------+            |
   // +----------------------------+
   // Default-on feature should be disabled in cross-origin child frame.
   Vector<String> messages;
   std::unique_ptr<FeaturePolicy> policy1 =
       createFromParentPolicy(nullptr, m_originA);
-  policy1->setHeaderPolicy("{\"default-on\": []}", messages);
+  policy1->setHeaderPolicy("{\"default-on\": []}", &messages);
   EXPECT_EQ(0UL, messages.size());
   std::unique_ptr<FeaturePolicy> policy2 =
       createFromParentPolicy(policy1.get(), m_originB);
   EXPECT_FALSE(policy2->isFeatureEnabled(kDefaultOnFeature));
 }
 
 TEST_F(FeaturePolicyTest, TestEnableForAllOrigins) {
   // +--------------------------------+
   // |(1) Origin A                    |
   // |Policy: {"default-self": ["*"]} |
   // | +-----------------+            |
   // | |(2) Origin B     |            |
   // | |No Policy        |            |
   // | | +-------------+ |            |
   // | | |(3)Origin A  | |            |
   // | | |No Policy    | |            |
   // | | +-------------+ |            |
   // | +-----------------+            |
   // +--------------------------------+
   // Feature should be enabled in top and second level; disabled in frame 3.
   Vector<String> messages;
   std::unique_ptr<FeaturePolicy> policy1 =
       createFromParentPolicy(nullptr, m_originA);
-  policy1->setHeaderPolicy("{\"default-self\": [\"*\"]}", messages);
+  policy1->setHeaderPolicy("{\"default-self\": [\"*\"]}", &messages);
   EXPECT_EQ(0UL, messages.size());
   std::unique_ptr<FeaturePolicy> policy2 =
       createFromParentPolicy(policy1.get(), m_originB);
   std::unique_ptr<FeaturePolicy> policy3 =
       createFromParentPolicy(policy2.get(), m_originA);
   EXPECT_TRUE(policy1->isFeatureEnabled(kDefaultSelfFeature));
   EXPECT_TRUE(policy2->isFeatureEnabled(kDefaultSelfFeature));
   EXPECT_FALSE(policy3->isFeatureEnabled(kDefaultSelfFeature));
 }
 
 TEST_F(FeaturePolicyTest, TestDefaultOnEnablesForAllAncestors) {
   // +---------------------------------------+
   // |(1) Origin A                           |
   // |Policy: {"default-on": ["Origin B"]}   |
   // | +-----------------------------------+ |
   // | |(2) Origin B                       | |
   // | |No Policy                          | |
   // | | +-------------+   +-------------+ | |
   // | | |(3)Origin B  |   |(4)Origin C  | | |
   // | | |No Policy    |   |No Policy    | | |
   // | | +-------------+   +-------------+ | |
   // | +-----------------------------------+ |
   // +---------------------------------------+
   // Feature should be disabled in frame 1; enabled in frames 2, 3 and 4.
   Vector<String> messages;
   std::unique_ptr<FeaturePolicy> policy1 =
       createFromParentPolicy(nullptr, m_originA);
-  policy1->setHeaderPolicy("{\"default-on\": [\"" ORIGIN_B "\"]}", messages);
+  policy1->setHeaderPolicy("{\"default-on\": [\"" ORIGIN_B "\"]}", &messages);
   EXPECT_EQ(0UL, messages.size());
   std::unique_ptr<FeaturePolicy> policy2 =
       createFromParentPolicy(policy1.get(), m_originB);
   std::unique_ptr<FeaturePolicy> policy3 =
       createFromParentPolicy(policy2.get(), m_originB);
   std::unique_ptr<FeaturePolicy> policy4 =
       createFromParentPolicy(policy2.get(), m_originC);
   EXPECT_FALSE(policy1->isFeatureEnabled(kDefaultOnFeature));
   EXPECT_TRUE(policy2->isFeatureEnabled(kDefaultOnFeature));
   EXPECT_TRUE(policy3->isFeatureEnabled(kDefaultOnFeature));
@@ skipping 10 matching lines @@
   // | | +-------------+   +-------------+ | |
   // | | |(3)Origin B  |   |(4)Origin C  | | |
   // | | |No Policy    |   |No Policy    | | |
   // | | +-------------+   +-------------+ | |
   // | +-----------------------------------+ |
   // +---------------------------------------+
   // Feature should be disabled in frames 1 and 4; enabled in frames 2 and 3.
   Vector<String> messages;
   std::unique_ptr<FeaturePolicy> policy1 =
       createFromParentPolicy(nullptr, m_originA);
-  policy1->setHeaderPolicy("{\"default-self\": [\"" ORIGIN_B "\"]}", messages);
+  policy1->setHeaderPolicy("{\"default-self\": [\"" ORIGIN_B "\"]}", &messages);
   EXPECT_EQ(0UL, messages.size());
   std::unique_ptr<FeaturePolicy> policy2 =
       createFromParentPolicy(policy1.get(), m_originB);
   std::unique_ptr<FeaturePolicy> policy3 =
       createFromParentPolicy(policy2.get(), m_originB);
   std::unique_ptr<FeaturePolicy> policy4 =
       createFromParentPolicy(policy2.get(), m_originC);
   EXPECT_FALSE(policy1->isFeatureEnabled(kDefaultSelfFeature));
   EXPECT_TRUE(policy2->isFeatureEnabled(kDefaultSelfFeature));
   EXPECT_TRUE(policy3->isFeatureEnabled(kDefaultSelfFeature));
@@ skipping 10 matching lines @@
   // | | +-------------+   +----------------------------------+ | |
   // | | |(3)Origin B  |   |(4)Origin C                       | | |
   // | | |No Policy    |   |Policy: {"default-off": ["self"]} | | |
   // | | +-------------+   +----------------------------------+ | |
   // | +--------------------------------------------------------+ |
   // +------------------------------------------------------------+
   // Feature should be disabled in frames 1, 3 and 4; enabled in frame 2 only.
   Vector<String> messages;
   std::unique_ptr<FeaturePolicy> policy1 =
       createFromParentPolicy(nullptr, m_originA);
-  policy1->setHeaderPolicy("{\"default-off\": [\"" ORIGIN_B "\"]}", messages);
+  policy1->setHeaderPolicy("{\"default-off\": [\"" ORIGIN_B "\"]}", &messages);
   EXPECT_EQ(0UL, messages.size());
   std::unique_ptr<FeaturePolicy> policy2 =
       createFromParentPolicy(policy1.get(), m_originB);
-  policy2->setHeaderPolicy("{\"default-off\": [\"self\"]}", messages);
+  policy2->setHeaderPolicy("{\"default-off\": [\"self\"]}", &messages);
   std::unique_ptr<FeaturePolicy> policy3 =
       createFromParentPolicy(policy2.get(), m_originB);
   std::unique_ptr<FeaturePolicy> policy4 =
       createFromParentPolicy(policy2.get(), m_originC);
-  policy4->setHeaderPolicy("{\"default-off\": [\"self\"]}", messages);
+  policy4->setHeaderPolicy("{\"default-off\": [\"self\"]}", &messages);
   EXPECT_FALSE(policy1->isFeatureEnabled(kDefaultOffFeature));
   EXPECT_TRUE(policy2->isFeatureEnabled(kDefaultOffFeature));
   EXPECT_FALSE(policy3->isFeatureEnabled(kDefaultOffFeature));
   EXPECT_FALSE(policy4->isFeatureEnabled(kDefaultOffFeature));
 }
 
 TEST_F(FeaturePolicyTest, TestReenableForAllOrigins) {
   // +------------------------------------+
   // |(1) Origin A                        |
   // |Policy: {"default-self": ["*"]}     |
   // | +--------------------------------+ |
   // | |(2) Origin B                    | |
   // | |Policy: {"default-self": ["*"]} | |
   // | | +-------------+                | |
   // | | |(3)Origin A  |                | |
   // | | |No Policy    |                | |
   // | | +-------------+                | |
   // | +--------------------------------+ |
   // +------------------------------------+
   // Feature should be enabled in all frames.
   Vector<String> messages;
   std::unique_ptr<FeaturePolicy> policy1 =
       createFromParentPolicy(nullptr, m_originA);
-  policy1->setHeaderPolicy("{\"default-self\": [\"*\"]}", messages);
+  policy1->setHeaderPolicy("{\"default-self\": [\"*\"]}", &messages);
   EXPECT_EQ(0UL, messages.size());
   std::unique_ptr<FeaturePolicy> policy2 =
       createFromParentPolicy(policy1.get(), m_originB);
-  policy2->setHeaderPolicy("{\"default-self\": [\"*\"]}", messages);
+  policy2->setHeaderPolicy("{\"default-self\": [\"*\"]}", &messages);
   EXPECT_EQ(0UL, messages.size());
   std::unique_ptr<FeaturePolicy> policy3 =
       createFromParentPolicy(policy2.get(), m_originA);
   EXPECT_TRUE(policy1->isFeatureEnabled(kDefaultSelfFeature));
   EXPECT_TRUE(policy2->isFeatureEnabled(kDefaultSelfFeature));
   EXPECT_TRUE(policy3->isFeatureEnabled(kDefaultSelfFeature));
 }
 
 TEST_F(FeaturePolicyTest, TestBlockedFrameCannotReenable) {
   // +--------------------------------------+
   // |(1)Origin A                           |
   // |Policy: {"default-self": ["self"]}    |
   // | +----------------------------------+ |
   // | |(2)Origin B                       | |
   // | |Policy: {"default-self": ["*"]}   | |
   // | | +-------------+  +-------------+ | |
   // | | |(3)Origin A  |  |(4)Origin C  | | |
   // | | |No Policy    |  |No Policy    | | |
   // | | +-------------+  +-------------+ | |
   // | +----------------------------------+ |
   // +--------------------------------------+
   // Feature should be enabled at the top level; disabled in all other frames.
   Vector<String> messages;
   std::unique_ptr<FeaturePolicy> policy1 =
       createFromParentPolicy(nullptr, m_originA);
-  policy1->setHeaderPolicy("{\"default-self\": [\"self\"]}", messages);
+  policy1->setHeaderPolicy("{\"default-self\": [\"self\"]}", &messages);
   EXPECT_EQ(0UL, messages.size());
   std::unique_ptr<FeaturePolicy> policy2 =
       createFromParentPolicy(policy1.get(), m_originB);
-  policy2->setHeaderPolicy("{\"default-self\": [\"*\"]}", messages);
+  policy2->setHeaderPolicy("{\"default-self\": [\"*\"]}", &messages);
   EXPECT_EQ(0UL, messages.size());
   std::unique_ptr<FeaturePolicy> policy3 =
       createFromParentPolicy(policy2.get(), m_originA);
   std::unique_ptr<FeaturePolicy> policy4 =
       createFromParentPolicy(policy2.get(), m_originC);
   EXPECT_TRUE(policy1->isFeatureEnabled(kDefaultSelfFeature));
   EXPECT_FALSE(policy2->isFeatureEnabled(kDefaultSelfFeature));
   EXPECT_FALSE(policy3->isFeatureEnabled(kDefaultSelfFeature));
   EXPECT_FALSE(policy4->isFeatureEnabled(kDefaultSelfFeature));
 }
 
 TEST_F(FeaturePolicyTest, TestEnabledFrameCanDelegate) {
   // +---------------------------------------------------+
   // |(1) Origin A                                       |
   // |Policy: {"default-self": ["self", "Origin B"]}     |
   // | +-----------------------------------------------+ |
   // | |(2) Origin B                                   | |
   // | |Policy: {"default-self": ["self", "Origin C"]} | |
   // | | +-------------+                               | |
   // | | |(3)Origin C  |                               | |
   // | | |No Policy    |                               | |
   // | | +-------------+                               | |
   // | +-----------------------------------------------+ |
   // +---------------------------------------------------+
   // Feature should be enabled in all frames.
   Vector<String> messages;
   std::unique_ptr<FeaturePolicy> policy1 =
       createFromParentPolicy(nullptr, m_originA);
   policy1->setHeaderPolicy("{\"default-self\": [\"self\", \"" ORIGIN_B "\"]}",
-                           messages);
+                           &messages);
   EXPECT_EQ(0UL, messages.size());
   std::unique_ptr<FeaturePolicy> policy2 =
       createFromParentPolicy(policy1.get(), m_originB);
   policy2->setHeaderPolicy("{\"default-self\": [\"self\", \"" ORIGIN_C "\"]}",
-                           messages);
+                           &messages);
   EXPECT_EQ(0UL, messages.size());
   std::unique_ptr<FeaturePolicy> policy3 =
       createFromParentPolicy(policy2.get(), m_originC);
   EXPECT_TRUE(policy1->isFeatureEnabled(kDefaultSelfFeature));
   EXPECT_TRUE(policy2->isFeatureEnabled(kDefaultSelfFeature));
   EXPECT_TRUE(policy3->isFeatureEnabled(kDefaultSelfFeature));
 }
 
 TEST_F(FeaturePolicyTest, TestEnabledFrameCanDelegateByDefault) {
   // +-----------------------------------------------+
   // |(1) Origin A                                   |
   // |Policy: {"default-on": ["self", "Origin B"]}   |
   // | +--------------------+ +--------------------+ |
   // | |(2) Origin B        | | (4) Origin C       | |
   // | |No Policy           | | No Policy          | |
   // | | +-------------+    | |                    | |
   // | | |(3)Origin C  |    | |                    | |
   // | | |No Policy    |    | |                    | |
   // | | +-------------+    | |                    | |
   // | +--------------------+ +--------------------+ |
   // +-----------------------------------------------+
   // Feature should be enabled in frames 1, 2, and 3, and disabled in frame 4.
   Vector<String> messages;
   std::unique_ptr<FeaturePolicy> policy1 =
       createFromParentPolicy(nullptr, m_originA);
   policy1->setHeaderPolicy("{\"default-on\": [\"self\", \"" ORIGIN_B "\"]}",
-                           messages);
+                           &messages);
   EXPECT_EQ(0UL, messages.size());
   std::unique_ptr<FeaturePolicy> policy2 =
       createFromParentPolicy(policy1.get(), m_originB);
   std::unique_ptr<FeaturePolicy> policy3 =
       createFromParentPolicy(policy2.get(), m_originC);
   std::unique_ptr<FeaturePolicy> policy4 =
       createFromParentPolicy(policy1.get(), m_originC);
   EXPECT_TRUE(policy1->isFeatureEnabled(kDefaultOnFeature));
   EXPECT_TRUE(policy2->isFeatureEnabled(kDefaultOnFeature));
   EXPECT_TRUE(policy3->isFeatureEnabled(kDefaultOnFeature));
@@ skipping 12 matching lines @@
   // | | |No Policy    |    | |                    | |
   // | | +-------------+    | |                    | |
   // | +--------------------+ +--------------------+ |
   // +-----------------------------------------------+
   // Feature should be enabled in frames 1 and 2, and disabled in frames 3 and
   // 4.
   Vector<String> messages;
   std::unique_ptr<FeaturePolicy> policy1 =
       createFromParentPolicy(nullptr, m_originA);
   policy1->setHeaderPolicy("{\"default-self\": [\"self\", \"" ORIGIN_B "\"]}",
-                           messages);
+                           &messages);
   EXPECT_EQ(0UL, messages.size());
   std::unique_ptr<FeaturePolicy> policy2 =
       createFromParentPolicy(policy1.get(), m_originB);
   std::unique_ptr<FeaturePolicy> policy3 =
       createFromParentPolicy(policy2.get(), m_originC);
   std::unique_ptr<FeaturePolicy> policy4 =
       createFromParentPolicy(policy1.get(), m_originC);
   EXPECT_TRUE(policy1->isFeatureEnabled(kDefaultSelfFeature));
   EXPECT_TRUE(policy2->isFeatureEnabled(kDefaultSelfFeature));
   EXPECT_FALSE(policy3->isFeatureEnabled(kDefaultSelfFeature));
@@ skipping 15 matching lines @@
   // | | +-------------+                           | |
   // | +-------------------------------------------+ |
   // +-----------------------------------------------+
   // Default-self feature should be enabled in all frames; Default-on feature
   // should be enabled in frame 1, and disabled in frames 2 and 3.
   Vector<String> messages;
   std::unique_ptr<FeaturePolicy> policy1 =
       createFromParentPolicy(nullptr, m_originA);
   policy1->setHeaderPolicy("{\"default-self\": [\"self\", \"" ORIGIN_B
                            "\"], \"default-on\": [\"self\"]}",
-                           messages);
+                           &messages);
   EXPECT_EQ(0UL, messages.size());
   std::unique_ptr<FeaturePolicy> policy2 =
       createFromParentPolicy(policy1.get(), m_originB);
   policy2->setHeaderPolicy(
-      "{\"default-self\": [\"*\"], \"default-on\": [\"*\"]}", messages);
+      "{\"default-self\": [\"*\"], \"default-on\": [\"*\"]}", &messages);
   EXPECT_EQ(0UL, messages.size());
   std::unique_ptr<FeaturePolicy> policy3 =
       createFromParentPolicy(policy2.get(), m_originC);
   EXPECT_TRUE(policy1->isFeatureEnabled(kDefaultSelfFeature));
   EXPECT_TRUE(policy1->isFeatureEnabled(kDefaultOnFeature));
   EXPECT_TRUE(policy2->isFeatureEnabled(kDefaultSelfFeature));
   EXPECT_FALSE(policy2->isFeatureEnabled(kDefaultOnFeature));
   EXPECT_TRUE(policy3->isFeatureEnabled(kDefaultSelfFeature));
   EXPECT_FALSE(policy3->isFeatureEnabled(kDefaultOnFeature));
 }
 
 TEST_F(FeaturePolicyTest, TestFeatureEnabledForOrigin) {
   // +-----------------------------------------------+
   // |(1) Origin A                                   |
   // |Policy: {"default-off": ["self", "Origin B"]}  |
   // +-----------------------------------------------+
   // Features should be enabled by the policy in frame 1 for origins A and B,
   // and disabled for origin C.
   Vector<String> messages;
   std::unique_ptr<FeaturePolicy> policy1 =
       createFromParentPolicy(nullptr, m_originA);
   policy1->setHeaderPolicy("{\"default-off\": [\"self\", \"" ORIGIN_B "\"]}",
-                           messages);
+                           &messages);
   EXPECT_EQ(0UL, messages.size());
   EXPECT_TRUE(
       policy1->isFeatureEnabledForOrigin(kDefaultOffFeature, *m_originA));
   EXPECT_TRUE(
       policy1->isFeatureEnabledForOrigin(kDefaultOffFeature, *m_originB));
   EXPECT_FALSE(
       policy1->isFeatureEnabledForOrigin(kDefaultOffFeature, *m_originC));
 }
 
 }  // namespace blink