third_party/WebKit/LayoutTests/http/tests/feature-policy/cross-origin-feature-disabled.php - Issue 2483703002: Replicate feature policy headers to remote frames

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/feature-policy/cross-origin-feature-disabled.php

Issue 2483703002: Replicate feature policy headers to remote frames (Closed)

Patch Set: Get replication actually working; add layout tests Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <?php

	2 Header("Feature-Policy: {\"docwrite\": [\"self\"]}");

	3 ?>

	4 <html>

	5 <head>

	6 <script>

	7 if (window.testRunner) {

	8 testRunner.dumpAsText();

	9 testRunner.dumpChildFramesAsText();
	alexmos 2016/11/09 01:16:55 Are these two calls needed? Doesn't seem like you Are these two calls needed? Doesn't seem like you have any expected.txt files.
	10 }

	11 </script>

	12 </head>

	13 <body>

	14 <p>This iframe should not return any errors:</p>

	15 <iframe src="http://localhost:8000/feature-policy/resources/cross-origin-iframe- for-feature-disabled.html"></iframe>

	16 <p>This iframe should not return any errors:</p>

	17 <iframe src="http://127.0.0.1:8000/feature-policy/resources/cross-origin-iframe- for-feature-enabled.html"></iframe>
	alexmos 2016/11/09 01:16:55 Did you intend for this second one to be a same-or Did you intend for this second one to be a same-origin or cross-origin frame? (i.e., should it be using localhost, like the first one?) iclelland 2016/11/09 18:07:59 That is intentional, to ensure that the feature is Show quoted text On 2016/11/09 01:16:55, alexmos wrote: > Did you intend for this second one to be a same-origin or cross-origin frame? > (i.e., should it be using localhost, like the first one?) That is intentional, to ensure that the feature is still enabled in a same-origin iframe. (The loaded html file filename should probably be changed)
	18 </body>

	19 </html>

OLD	NEW