Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: third_party/WebKit/Source/core/frame/FeaturePolicyInFrameTest.cpp

Issue 2483703002: Replicate feature policy headers to remote frames (Closed)
Patch Set: Add browsertest for subframe navigation Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "platform/feature_policy/FeaturePolicy.h" 5 #include "platform/feature_policy/FeaturePolicy.h"
6 6
7 #include "bindings/core/v8/ConditionalFeatures.h" 7 #include "bindings/core/v8/ConditionalFeatures.h"
8 #include "core/frame/LocalFrame.h" 8 #include "core/frame/LocalFrame.h"
9 #include "core/testing/DummyPageHolder.h" 9 #include "core/testing/DummyPageHolder.h"
10 #include "platform/RuntimeEnabledFeatures.h" 10 #include "platform/RuntimeEnabledFeatures.h"
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
70 std::unique_ptr<DummyPageHolder> m_dummyPageHolder; 70 std::unique_ptr<DummyPageHolder> m_dummyPageHolder;
71 71
72 // Contains the list of controlled features, so that we are guaranteed to 72 // Contains the list of controlled features, so that we are guaranteed to
73 // have at least one of each kind of default behaviour represented. 73 // have at least one of each kind of default behaviour represented.
74 FeaturePolicy::FeatureList m_featureList; 74 FeaturePolicy::FeatureList m_featureList;
75 }; 75 };
76 76
77 TEST_F(FeaturePolicyInFrameTest, TestFeatureDefaultsInTopLevelFrame) { 77 TEST_F(FeaturePolicyInFrameTest, TestFeatureDefaultsInTopLevelFrame) {
78 std::unique_ptr<FeaturePolicy> policy1 = 78 std::unique_ptr<FeaturePolicy> policy1 =
79 createFromParentPolicy(nullptr, m_originA); 79 createFromParentPolicy(nullptr, m_originA);
80 document().setFeaturePolicy(std::move(policy1)); 80 document().setFeaturePolicyForTesting(std::move(policy1));
81 EXPECT_TRUE(isFeatureEnabledInFrame(kDefaultOnFeature, frame())); 81 EXPECT_TRUE(isFeatureEnabledInFrame(kDefaultOnFeature, frame()));
82 EXPECT_TRUE(isFeatureEnabledInFrame(kDefaultSelfFeature, frame())); 82 EXPECT_TRUE(isFeatureEnabledInFrame(kDefaultSelfFeature, frame()));
83 EXPECT_FALSE(isFeatureEnabledInFrame(kDefaultOffFeature, frame())); 83 EXPECT_FALSE(isFeatureEnabledInFrame(kDefaultOffFeature, frame()));
84 } 84 }
85 85
86 TEST_F(FeaturePolicyInFrameTest, TestFeatureDefaultsInCrossOriginFrame) { 86 TEST_F(FeaturePolicyInFrameTest, TestFeatureDefaultsInCrossOriginFrame) {
87 std::unique_ptr<FeaturePolicy> policy1 = 87 std::unique_ptr<FeaturePolicy> policy1 =
88 createFromParentPolicy(nullptr, m_originB); 88 createFromParentPolicy(nullptr, m_originB);
89 std::unique_ptr<FeaturePolicy> policy2 = 89 std::unique_ptr<FeaturePolicy> policy2 =
90 createFromParentPolicy(policy1.get(), m_originA); 90 createFromParentPolicy(policy1.get(), m_originA);
91 document().setFeaturePolicy(std::move(policy2)); 91 document().setFeaturePolicyForTesting(std::move(policy2));
92 EXPECT_TRUE(isFeatureEnabledInFrame(kDefaultOnFeature, frame())); 92 EXPECT_TRUE(isFeatureEnabledInFrame(kDefaultOnFeature, frame()));
93 EXPECT_FALSE(isFeatureEnabledInFrame(kDefaultSelfFeature, frame())); 93 EXPECT_FALSE(isFeatureEnabledInFrame(kDefaultSelfFeature, frame()));
94 EXPECT_FALSE(isFeatureEnabledInFrame(kDefaultOffFeature, frame())); 94 EXPECT_FALSE(isFeatureEnabledInFrame(kDefaultOffFeature, frame()));
95 } 95 }
96 96
97 TEST_F(FeaturePolicyInFrameTest, TestFeatureOverriddenInFrame) { 97 TEST_F(FeaturePolicyInFrameTest, TestFeatureOverriddenInFrame) {
98 Vector<String> messages; 98 Vector<String> messages;
99 std::unique_ptr<FeaturePolicy> policy1 = 99 std::unique_ptr<FeaturePolicy> policy1 =
100 createFromParentPolicy(nullptr, m_originA); 100 createFromParentPolicy(nullptr, m_originA);
101 policy1->setHeaderPolicy("{\"default-off\": [\"self\"], \"default-on\": []}", 101 policy1->setHeaderPolicy("{\"default-off\": [\"self\"], \"default-on\": []}",
102 messages); 102 &messages);
103 EXPECT_EQ(0UL, messages.size()); 103 EXPECT_EQ(0UL, messages.size());
104 document().setFeaturePolicy(std::move(policy1)); 104 document().setFeaturePolicyForTesting(std::move(policy1));
105 EXPECT_TRUE(isFeatureEnabledInFrame(kDefaultOffFeature, frame())); 105 EXPECT_TRUE(isFeatureEnabledInFrame(kDefaultOffFeature, frame()));
106 EXPECT_FALSE(isFeatureEnabledInFrame(kDefaultOnFeature, frame())); 106 EXPECT_FALSE(isFeatureEnabledInFrame(kDefaultOnFeature, frame()));
107 } 107 }
108 108
109 // Ensure that features are enabled / disabled correctly when the FP runtime 109 // Ensure that features are enabled / disabled correctly when the FP runtime
110 // flag is turned off. 110 // flag is turned off.
111 TEST_F(FeaturePolicyInFrameTest, TestFeatureDefaultsWhenFPDisabled) { 111 TEST_F(FeaturePolicyInFrameTest, TestFeatureDefaultsWhenFPDisabled) {
112 RuntimeEnabledFeatures::setFeaturePolicyEnabled(false); 112 RuntimeEnabledFeatures::setFeaturePolicyEnabled(false);
113 EXPECT_TRUE(isFeatureEnabledInFrame(kDefaultOnFeature, frame())); 113 EXPECT_TRUE(isFeatureEnabledInFrame(kDefaultOnFeature, frame()));
114 EXPECT_TRUE(isFeatureEnabledInFrame(kDefaultSelfFeature, frame())); 114 EXPECT_TRUE(isFeatureEnabledInFrame(kDefaultSelfFeature, frame()));
115 EXPECT_FALSE(isFeatureEnabledInFrame(kDefaultOffFeature, frame())); 115 EXPECT_FALSE(isFeatureEnabledInFrame(kDefaultOffFeature, frame()));
116 } 116 }
117 117
118 // Ensure that feature policy has no effect when the FP runtime flag is turned 118 // Ensure that feature policy has no effect when the FP runtime flag is turned
119 // off. 119 // off.
120 TEST_F(FeaturePolicyInFrameTest, TestPolicyInactiveWhenFPDisabled) { 120 TEST_F(FeaturePolicyInFrameTest, TestPolicyInactiveWhenFPDisabled) {
121 RuntimeEnabledFeatures::setFeaturePolicyEnabled(false); 121 RuntimeEnabledFeatures::setFeaturePolicyEnabled(false);
122 Vector<String> messages; 122 Vector<String> messages;
123 std::unique_ptr<FeaturePolicy> policy1 = 123 std::unique_ptr<FeaturePolicy> policy1 =
124 createFromParentPolicy(nullptr, m_originA); 124 createFromParentPolicy(nullptr, m_originA);
125 policy1->setHeaderPolicy("{\"default-on\": []}", messages); 125 policy1->setHeaderPolicy("{\"default-on\": []}", &messages);
126 EXPECT_EQ(0UL, messages.size()); 126 EXPECT_EQ(0UL, messages.size());
127 document().setFeaturePolicy(std::move(policy1)); 127 document().setFeaturePolicyForTesting(std::move(policy1));
128 EXPECT_TRUE(isFeatureEnabledInFrame(kDefaultOnFeature, frame())); 128 EXPECT_TRUE(isFeatureEnabledInFrame(kDefaultOnFeature, frame()));
129 } 129 }
130 130
131 } // namespace blink 131 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698