Replicate feature policy headers to remote frames

content/renderer/render_frame_proxy.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/render_frame_proxy.h"
 
 #include <stdint.h>
 #include <map>
 #include <utility>
 
@@ skipping 208 matching lines @@
 
 void RenderFrameProxy::SetReplicatedState(const FrameReplicationState& state) {
   DCHECK(web_frame_);
   web_frame_->setReplicatedOrigin(state.origin);
   web_frame_->setReplicatedSandboxFlags(state.sandbox_flags);
   web_frame_->setReplicatedName(blink::WebString::fromUTF8(state.name),
                                 blink::WebString::fromUTF8(state.unique_name));
   web_frame_->setReplicatedInsecureRequestPolicy(state.insecure_request_policy);
   web_frame_->setReplicatedPotentiallyTrustworthyUniqueOrigin(
       state.has_potentially_trustworthy_unique_origin);
+  web_frame_->resetReplicatedContentSecurityPolicy();

[raymes, 2016/11/07 02:16:01]

This calls the wrong thing by the looks of it!

[iclelland, 2016/11/07 03:37:03]

Quite likely :) This is all very very WIP; not nearly ready for review. I wanted
to make sure you were aware of the space I'd been working in, so we didn't
duplicate efforts.

+  for (const auto& header : state.feature_policy_headers)
+    web_frame_->addReplicatedFeaturePolicyHeader(

[raymes, 2016/11/07 02:16:01]

Similarly here, I think we could just get rid of the array and do
setReplicatedFeaturePolicyHeader rather than addReplicatedFeaturePolicyHeader.

The same in all the other places where we have add (as opposed to set).

If we're able to do that then reset probably is unnecessary

[iclelland, 2016/11/07 03:37:03]

Agreed. Since the headers are already fully received and combined by this point,
there's no need for the vector.

+        blink::WebString::fromUTF8(header));
 
   web_frame_->resetReplicatedContentSecurityPolicy();
   for (const auto& header : state.accumulated_csp_headers)
     OnAddContentSecurityPolicy(header);
 }
 
 // Update the proxy's SecurityContext and FrameOwner with new sandbox flags
 // that were set by its parent in another process.
 //
 // Normally, when a frame's sandbox attribute is changed dynamically, the
@@ skipping 268 matching lines @@
                                     blink::WebLocalFrame* source) {
   int source_routing_id = RenderFrameImpl::FromWebFrame(source)->GetRoutingID();
   Send(new FrameHostMsg_AdvanceFocus(routing_id_, type, source_routing_id));
 }
 
 void RenderFrameProxy::frameFocused() {
   Send(new FrameHostMsg_FrameFocused(routing_id_));
 }
 
 }  // namespace