Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1009)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_length_utils_test.cc

Issue 2483683003: [LayoutNG] Split apart storage for AvailableSize and PercentageSize. (Closed)
Patch Set: rebase. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/ng/ng_length_utils_test.cc
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_length_utils_test.cc b/third_party/WebKit/Source/core/layout/ng/ng_length_utils_test.cc
index 5f88d702cb30b92217112f73f109d1a3afb91792..31720a438288d803092ba6ce04f232dcdf703e73 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_length_utils_test.cc
+++ b/third_party/WebKit/Source/core/layout/ng/ng_length_utils_test.cc
@@ -5,6 +5,7 @@
#include "core/layout/ng/ng_length_utils.h"
#include "core/layout/ng/ng_constraint_space.h"
+#include "core/layout/ng/ng_constraint_space_builder.h"
#include "core/layout/ng/ng_fragment.h"
#include "core/layout/ng/ng_fragment_builder.h"
#include "core/layout/ng/ng_physical_fragment.h"
@@ -27,12 +28,17 @@ class NGLengthUtilsTest : public ::testing::Test {
int block_size,
bool fixed_inline = false,
bool fixed_block = false) {
- return new NGConstraintSpace(
- HorizontalTopBottom, LeftToRight,
- new NGPhysicalConstraintSpace(
- NGPhysicalSize(LayoutUnit(inline_size), LayoutUnit(block_size)),
- fixed_inline, fixed_block, false, false, FragmentNone, FragmentNone,
- false));
+ NGConstraintSpaceBuilder builder(HorizontalTopBottom);
+ builder
+ .SetAvailableSize(
+ NGLogicalSize(LayoutUnit(inline_size), LayoutUnit(block_size)))
+ .SetPercentageResolutionSize(
+ NGLogicalSize(LayoutUnit(inline_size), LayoutUnit(block_size)))
+ .SetIsFixedSizeInline(fixed_inline)
+ .SetIsFixedSizeBlock(fixed_block);
+
+ return new NGConstraintSpace(HorizontalTopBottom, LeftToRight,
+ builder.ToConstraintSpace());
}
LayoutUnit ResolveInlineLength(

Powered by Google App Engine
This is Rietveld 408576698