Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2483683002: Try to get rid of all direct references to particular native themes. (Closed)

Created:
4 years, 1 month ago by Evan Stade
Modified:
4 years ago
Reviewers:
CC:
chromium-reviews, tfarina, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Try to get rid of all direct references to particular native themes. BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -77 lines) Patch
M chrome/browser/ui/views/frame/browser_view.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ui/native_theme/native_theme.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/native_theme/native_theme_android.h View 2 chunks +3 lines, -2 lines 0 comments Download
M ui/native_theme/native_theme_android.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M ui/native_theme/native_theme_aura.h View 2 chunks +6 lines, -3 lines 0 comments Download
M ui/native_theme/native_theme_aura.cc View 6 chunks +38 lines, -34 lines 0 comments Download
M ui/native_theme/native_theme_dark_aura.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/native_theme/native_theme_mac.h View 2 chunks +4 lines, -2 lines 0 comments Download
M ui/native_theme/native_theme_mac.mm View 1 chunk +5 lines, -0 lines 0 comments Download
M ui/native_theme/native_theme_win.h View 2 chunks +4 lines, -3 lines 0 comments Download
M ui/native_theme/native_theme_win.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/views/mus/native_widget_mus.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/view.cc View 1 chunk +1 line, -8 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_chromeos.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_win.cc View 1 chunk +1 line, -11 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc View 2 chunks +1 line, -2 lines 0 comments Download
M ui/views/widget/native_widget_aura.cc View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 4 (4 generated)
Evan Stade
The CQ bit was checked by estade@chromium.org to run a CQ dry run
4 years, 1 month ago (2016-11-06 02:21:08 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2483683002/1
4 years, 1 month ago (2016-11-06 02:21:15 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 1 month ago (2016-11-06 02:35:04 UTC) #3
commit-bot: I haz the power
4 years, 1 month ago (2016-11-06 02:35:04 UTC) #4 
Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

Powered by Google App Engine
This is Rietveld 408576698