Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2483623002:
Make SurfaceFactory lifetime match frame_sink_id_ registration in DelegatedFrameHost (Closed)
|
Created:
4 years, 1 month ago by piman Modified:
4 years, 1 month ago Reviewers:
Fady Samuel CC:
chromium-reviews, jam, jbauman+watch_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, kalyank, danakj+watch_chromium.org, xjz+watch_chromium.org, miu+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMake SurfaceFactory lifetime match frame_sink_id_ registration in DelegatedFrameHost
This will allow further simplification/refactoring.
BUG=657959
Committed: https://crrev.com/65473635222ea5062169a2861e641019fcda1efb
Cr-Commit-Position: refs/heads/master@{#430449}
Patch Set 1 #Patch Set 2 : rebase #Patch Set 3 : rebase #
Messages
Total messages: 21 (14 generated)
The CQ bit was checked by piman@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by piman@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by piman@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
piman@chromium.org changed reviewers: + fsamuel@chromium.org
lgtm
The CQ bit was unchecked by piman@chromium.org
The CQ bit was checked by piman@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by piman@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Make SurfaceFactory lifetime match frame_sink_id_ registration in DelegatedFrameHost This will allow further simplification/refactoring. BUG=657959 ========== to ========== Make SurfaceFactory lifetime match frame_sink_id_ registration in DelegatedFrameHost This will allow further simplification/refactoring. BUG=657959 Committed: https://crrev.com/65473635222ea5062169a2861e641019fcda1efb Cr-Commit-Position: refs/heads/master@{#430449} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/65473635222ea5062169a2861e641019fcda1efb Cr-Commit-Position: refs/heads/master@{#430449} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
