Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Side by Side Diff: content/renderer/render_widget_fullscreen.cc

Issue 2483593002: RenderWidget: hoist synchronous IPC out of Init methods. (Closed)
Patch Set: Rework Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/renderer/render_widget_fullscreen.h" 5 #include "content/renderer/render_widget_fullscreen.h"
6 6
7 #include "content/common/view_messages.h" 7 #include "content/common/view_messages.h"
8 #include "content/renderer/render_thread_impl.h" 8 #include "content/renderer/render_thread_impl.h"
9 #include "third_party/WebKit/public/web/WebWidget.h" 9 #include "third_party/WebKit/public/web/WebWidget.h"
10 10
(...skipping 23 matching lines...) Expand all
34 false, 34 false,
35 false) {} 35 false) {}
36 36
37 RenderWidgetFullscreen::~RenderWidgetFullscreen() {} 37 RenderWidgetFullscreen::~RenderWidgetFullscreen() {}
38 38
39 WebWidget* RenderWidgetFullscreen::CreateWebWidget() { 39 WebWidget* RenderWidgetFullscreen::CreateWebWidget() {
40 // TODO(boliu): Handle full screen render widgets here. 40 // TODO(boliu): Handle full screen render widgets here.
41 return RenderWidget::CreateWebWidget(this); 41 return RenderWidget::CreateWebWidget(this);
42 } 42 }
43 43
44 bool RenderWidgetFullscreen::SendIPC(int32_t opener_id, int32_t* routing_id) {
45 return RenderThread::Get()->Send(
46 new ViewHostMsg_CreateFullscreenWidget(opener_id, routing_id));
47 }
48
49 bool RenderWidgetFullscreen::Init(int32_t opener_id) { 44 bool RenderWidgetFullscreen::Init(int32_t opener_id) {
50 DCHECK(!GetWebWidget()); 45 DCHECK(!GetWebWidget());
51 46
52 bool success = RenderWidget::DoInit( 47 // Synchronous IPC to obtain a routing id for ourselves.
53 opener_id, CreateWebWidget(), 48 int32_t routing_id = MSG_ROUTING_NONE;
54 base::Bind(&RenderWidgetFullscreen::SendIPC, base::Unretained(this), 49 RenderThread::Get()->Send(
55 opener_id, &routing_id_)); 50 new ViewHostMsg_CreateFullscreenWidget(opener_id, &routing_id));
56 51
57 if (success) { 52 if (routing_id == MSG_ROUTING_NONE)
58 // TODO(fsamuel): This is a bit ugly. The |create_widget_message| should 53 return false;
59 // probably be factored out of RenderWidget::DoInit. 54
60 SetRoutingID(routing_id_); 55 RenderWidget::Init(routing_id, opener_id, CreateWebWidget());
61 return true; 56 return true;
62 }
63 return false;
64 } 57 }
65 58
66 } // namespace content 59 } // namespace content
OLDNEW
« content/renderer/render_widget.cc ('K') | « content/renderer/render_widget.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698