Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 2483573002: [CUPS] USB printer setup notification: direct the user to settings page if failed. (Closed)

Created:
4 years, 1 month ago by xdai1
Modified:
4 years ago
Reviewers:
stevenjb
CC:
chromium-reviews, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[CUPS] USB printer setup notification: direct the user to settings page if failed. Small bug fix. BUG=625382, 626752 Committed: https://crrev.com/55d0bc271648529ca6c4e204290c8edb71eda8cb Cr-Commit-Position: refs/heads/master@{#434751}

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -9 lines) Patch
M chrome/browser/chromeos/printer_detector/printer_detector.cc View 2 chunks +6 lines, -9 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
xdai1
stevenjb@, could you help review this CL please? It's just a tiny bug fix. Thanks!
4 years, 1 month ago (2016-11-04 23:09:14 UTC) #2
stevenjb
lgtm
4 years, 1 month ago (2016-11-09 18:20:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2483573002/20001
4 years ago (2016-11-28 20:42:15 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-11-28 22:48:20 UTC) #8
commit-bot: I haz the power
4 years ago (2016-11-28 22:52:41 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/55d0bc271648529ca6c4e204290c8edb71eda8cb
Cr-Commit-Position: refs/heads/master@{#434751}

Powered by Google App Engine
This is Rietveld 408576698