Fix the issue of alpha = 254 instead of 255

Fix the sum of alpha = 254 instead of 255 by rounding

This patch is a subpatch from https://codereview.chromium.org/2471133002/

I created this CL mainly for Florin to land before he rebaseline the Chrome
layout tests. (Landing the whole patch of 2471133002 would be nice but most
people already left for the weekend so I'd rather not take the risk to break
the Skia during the weekend.)

BUG=skia:

TBR=reed@google.com, mtklein@google.com, fmalita@chromium.org
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2483523002

Committed: https://skia.googlesource.com/skia/+/525e13c1d318b067e679d7ca540fc1436c38385b

[liyuqian, 2016-11-04 21:38:53]

Description was changed from

==========
Fix the issue of alpha = 254 instead of 255

This patch is a subpatch from https://codereview.chromium.org/2471133002/

I created this CL mainly for Florin to land before he rebaseline the Chrome
layout tests. (Landing the whole patch of 2471133002 would be nice but most
people already left for the weekend so I'd rather not take the risk to break
the Skia for the weekend.).

BUG=skia:

TBR=reed@google.com, mtklein@google.com, fmalita@chromium.org
==========

to

==========
Fix the issue of alpha = 254 instead of 255

This patch is a subpatch from https://codereview.chromium.org/2471133002/

I created this CL mainly for Florin to land before he rebaseline the Chrome
layout tests. (Landing the whole patch of 2471133002 would be nice but most
people already left for the weekend so I'd rather not take the risk to break
the Skia for the weekend.).

BUG=skia:

TBR=reed@google.com, mtklein@google.com, fmalita@chromium.org
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2483523002
==========

[liyuqian, 2016-11-04 21:42:52]

Description was changed from

==========
Fix the issue of alpha = 254 instead of 255

This patch is a subpatch from https://codereview.chromium.org/2471133002/

I created this CL mainly for Florin to land before he rebaseline the Chrome
layout tests. (Landing the whole patch of 2471133002 would be nice but most
people already left for the weekend so I'd rather not take the risk to break
the Skia for the weekend.).

BUG=skia:

TBR=reed@google.com, mtklein@google.com, fmalita@chromium.org
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2483523002
==========

to

==========
Fix the issue of alpha = 254 instead of 255 by rounding

This patch is a subpatch from https://codereview.chromium.org/2471133002/

I created this CL mainly for Florin to land before he rebaseline the Chrome
layout tests. (Landing the whole patch of 2471133002 would be nice but most
people already left for the weekend so I'd rather not take the risk to break
the Skia for the weekend.).

BUG=skia:

TBR=reed@google.com, mtklein@google.com, fmalita@chromium.org
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2483523002
==========

[liyuqian, 2016-11-04 21:43:16]

Description was changed from

==========
Fix the issue of alpha = 254 instead of 255 by rounding

This patch is a subpatch from https://codereview.chromium.org/2471133002/

I created this CL mainly for Florin to land before he rebaseline the Chrome
layout tests. (Landing the whole patch of 2471133002 would be nice but most
people already left for the weekend so I'd rather not take the risk to break
the Skia for the weekend.).

BUG=skia:

TBR=reed@google.com, mtklein@google.com, fmalita@chromium.org
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2483523002
==========

to

==========
Fix the issue of alpha = 254 instead of 255 by rounding

This patch is a subpatch from https://codereview.chromium.org/2471133002/

I created this CL mainly for Florin to land before he rebaseline the Chrome
layout tests. (Landing the whole patch of 2471133002 would be nice but most
people already left for the weekend so I'd rather not take the risk to break
the Skia during the weekend.)

BUG=skia:

TBR=reed@google.com, mtklein@google.com, fmalita@chromium.org
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2483523002
==========

[liyuqian, 2016-11-04 21:45:58]

Hi Florin, some unittests in Skia caught this issue and I just fixed it. It
might be related with our strange (dR <= 1, dG <= 1, dB <= 1) issue. I think
that you can land it TBR without breaking Skia. It shall save you some time for
rebaselining?

[liyuqian, 2016-11-04 21:47:00]

Description was changed from

==========
Fix the issue of alpha = 254 instead of 255 by rounding

This patch is a subpatch from https://codereview.chromium.org/2471133002/

I created this CL mainly for Florin to land before he rebaseline the Chrome
layout tests. (Landing the whole patch of 2471133002 would be nice but most
people already left for the weekend so I'd rather not take the risk to break
the Skia during the weekend.)

BUG=skia:

TBR=reed@google.com, mtklein@google.com, fmalita@chromium.org
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2483523002
==========

to

==========
Fix the sum of alpha = 254 instead of 255 by rounding

This patch is a subpatch from https://codereview.chromium.org/2471133002/

I created this CL mainly for Florin to land before he rebaseline the Chrome
layout tests. (Landing the whole patch of 2471133002 would be nice but most
people already left for the weekend so I'd rather not take the risk to break
the Skia during the weekend.)

BUG=skia:

TBR=reed@google.com, mtklein@google.com, fmalita@chromium.org
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2483523002
==========

[liyuqian, 2016-11-04 21:47:11]

The CQ bit was checked by liyuqian@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-04 21:47:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 22:26:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 22:26:30]

Dry run: This issue passed the CQ dry run.

[liyuqian, 2016-11-05 13:33:22]

The CQ bit was checked by liyuqian@google.com

[commit-bot: I haz the power, 2016-11-05 13:33:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-05 13:34:24]

Description was changed from

==========
Fix the sum of alpha = 254 instead of 255 by rounding

This patch is a subpatch from https://codereview.chromium.org/2471133002/

I created this CL mainly for Florin to land before he rebaseline the Chrome
layout tests. (Landing the whole patch of 2471133002 would be nice but most
people already left for the weekend so I'd rather not take the risk to break
the Skia during the weekend.)

BUG=skia:

TBR=reed@google.com, mtklein@google.com, fmalita@chromium.org
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2483523002
==========

to

==========
Fix the sum of alpha = 254 instead of 255 by rounding

This patch is a subpatch from https://codereview.chromium.org/2471133002/

I created this CL mainly for Florin to land before he rebaseline the Chrome
layout tests. (Landing the whole patch of 2471133002 would be nice but most
people already left for the weekend so I'd rather not take the risk to break
the Skia during the weekend.)

BUG=skia:

TBR=reed@google.com, mtklein@google.com, fmalita@chromium.org
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2483523002

Committed:
https://skia.googlesource.com/skia/+/525e13c1d318b067e679d7ca540fc1436c38385b
==========

[commit-bot: I haz the power, 2016-11-05 13:34:25]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/525e13c1d318b067e679d7ca540fc1436c38385b

[fmalita_google_do_not_use, 2016-11-05 14:30:20]

On 2016/11/04 21:45:58, liyuqian wrote:
> Hi Florin, some unittests in Skia caught this issue and I just fixed it. It
> might be related with our strange (dR <= 1, dG <= 1, dB <= 1) issue. I think
> that you can land it TBR without breaking Skia. It shall save you some time
for
> rebaselining?

Thanks, so we want this rolled into Chrome before rebaselining.  But I see the
auto-roller is stopped for some reason, do you know who stopped it/why?

[fmalita_google_do_not_use, 2016-11-05 14:31:02]

On 2016/11/05 14:30:20, fmalita_google_do_not_use wrote:
> On 2016/11/04 21:45:58, liyuqian wrote:
> > Hi Florin, some unittests in Skia caught this issue and I just fixed it. It
> > might be related with our strange (dR <= 1, dG <= 1, dB <= 1) issue. I think
> > that you can land it TBR without breaking Skia. It shall save you some time
> for
> > rebaselining?
> 
> Thanks, so we want this rolled into Chrome before rebaselining.  But I see the
> auto-roller is stopped for some reason, do you know who stopped it/why?

I turned it back on.