Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(523)

Unified Diff: components/update_client/action_update.h

Issue 2483513002: Revert of Makes the component installers return a Result instead of a bool. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/update_client/action_update.h
diff --git a/components/update_client/action_update.h b/components/update_client/action_update.h
index 7b6297153f633b6338eb0203fa6031504e683ee6..c6fa4e7bb1202d3c53396244958ac313cacb757f 100644
--- a/components/update_client/action_update.h
+++ b/components/update_client/action_update.h
@@ -58,8 +58,7 @@
virtual void OnInstallStart(CrxUpdateItem* item) = 0;
virtual void OnInstallSuccess(CrxUpdateItem* item) = 0;
virtual void OnInstallError(CrxUpdateItem* item,
- ErrorCategory error_category,
- int error,
+ UnpackerError error,
int extended_error) = 0;
void StartDownload(CrxUpdateItem* item);
@@ -74,8 +73,7 @@
void StartInstall(CrxUpdateItem* item, const base::FilePath& crx_path);
void InstallComplete(const std::string& id,
- ErrorCategory error_category,
- int error,
+ UnpackerError error,
int extended_error);
void StartUnpackOnBlockingTaskRunner(CrxUpdateItem* item,
@@ -90,13 +88,14 @@
const base::FilePath& unpack_path);
void InstallCompleteOnBlockingTaskRunner(CrxUpdateItem* item,
const base::FilePath& crx_path,
- ErrorCategory error_category,
- int error,
+ UnpackerError error,
int extended_error);
- CrxInstaller::Result DoInstall(CrxUpdateItem* item,
- const base::FilePath& crx_path,
- const base::FilePath& unpack_path);
+ // TODO(sorin): make this function return a result data type to convey
+ // extended error information.
+ UnpackerError DoInstall(CrxUpdateItem* item,
+ const base::FilePath& crx_path,
+ const base::FilePath& unpack_path);
// Downloads updates for one CRX id only.
std::unique_ptr<CrxDownloader> crx_downloader_;
@@ -129,8 +128,7 @@
void OnInstallStart(CrxUpdateItem* item) override;
void OnInstallSuccess(CrxUpdateItem* item) override;
void OnInstallError(CrxUpdateItem* item,
- ErrorCategory error_category,
- int error,
+ UnpackerError error,
int extended_error) override;
DISALLOW_COPY_AND_ASSIGN(ActionUpdateDiff);
@@ -156,8 +154,7 @@
void OnInstallStart(CrxUpdateItem* item) override;
void OnInstallSuccess(CrxUpdateItem* item) override;
void OnInstallError(CrxUpdateItem* item,
- ErrorCategory error_category,
- int error,
+ UnpackerError error,
int extended_error) override;
DISALLOW_COPY_AND_ASSIGN(ActionUpdateFull);
« no previous file with comments | « components/component_updater/default_component_installer_unittest.cc ('k') | components/update_client/action_update.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698