Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 2483493002: android: Don't run failing FontTest.DeriveFont; run gfx_unittests on bots. (Closed)

Created:
4 years, 1 month ago by Nico
Modified:
4 years, 1 month ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

android: run gfx_unittests on bots. Also disable a few tests that don't pass on Android. BUG=662559, 642010, 662556, 662558, 662561 Committed: https://crrev.com/c10e8e86d03fb5308bc00d1d468662e6eff59268 Cr-Commit-Position: refs/heads/master@{#431157}

Patch Set 1 #

Total comments: 2

Patch Set 2 : comments; more #

Patch Set 3 : more bug links #

Patch Set 4 : include build_config.h more #

Unified diffs Side-by-side diffs Delta from patch set Stats (+172 lines, -4 lines) Patch
M testing/buildbot/chromium.android.json View 10 chunks +144 lines, -0 lines 0 comments Download
M ui/gfx/font_unittest.cc View 1 1 chunk +7 lines, -1 line 0 comments Download
M ui/gfx/geometry/quad_unittest.cc View 1 2 3 2 chunks +4 lines, -0 lines 0 comments Download
M ui/gfx/geometry/vector3d_unittest.cc View 1 2 3 2 chunks +8 lines, -1 line 0 comments Download
M ui/gfx/platform_font_android.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M ui/gfx/transform_unittest.cc View 1 2 3 3 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 32 (21 generated)
Nico
karandeepb: Test disablement (see bug from some discussion) stip: All the json copypasta (do we ...
4 years, 1 month ago (2016-11-04 19:29:06 UTC) #4
karandeepb
https://codereview.chromium.org/2483493002/diff/1/ui/gfx/font_unittest.cc File ui/gfx/font_unittest.cc (right): https://codereview.chromium.org/2483493002/diff/1/ui/gfx/font_unittest.cc#newcode165 ui/gfx/font_unittest.cc:165: #if defined(TOOLKIT_VIEWS) Think this should be disabled explicitly on ...
4 years, 1 month ago (2016-11-07 00:00:23 UTC) #7
Nico
https://codereview.chromium.org/2483493002/diff/1/ui/gfx/font_unittest.cc File ui/gfx/font_unittest.cc (right): https://codereview.chromium.org/2483493002/diff/1/ui/gfx/font_unittest.cc#newcode165 ui/gfx/font_unittest.cc:165: #if defined(TOOLKIT_VIEWS) On 2016/11/07 00:00:22, karandeepb wrote: > Think ...
4 years, 1 month ago (2016-11-07 00:04:26 UTC) #8
karandeepb
On 2016/11/07 00:04:26, Nico (mostly afk Wed-Fri) wrote: > https://codereview.chromium.org/2483493002/diff/1/ui/gfx/font_unittest.cc > File ui/gfx/font_unittest.cc (right): > ...
4 years, 1 month ago (2016-11-07 00:06:04 UTC) #9
Nico
karandeepb: Done, please also review ui/gfx/platform_font_android.cc stip: ping! danakj, enne: Please look at the files ...
4 years, 1 month ago (2016-11-09 20:33:45 UTC) #16
danakj
LGTM
4 years, 1 month ago (2016-11-09 20:45:42 UTC) #17
ghost stip (do not use)
lgtm
4 years, 1 month ago (2016-11-09 20:46:01 UTC) #18
karandeepb
LGTM
4 years, 1 month ago (2016-11-09 23:53:10 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2483493002/60001
4 years, 1 month ago (2016-11-10 02:54:51 UTC) #28
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 1 month ago (2016-11-10 03:03:45 UTC) #30
commit-bot: I haz the power
4 years, 1 month ago (2016-11-10 03:08:41 UTC) #32
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/c10e8e86d03fb5308bc00d1d468662e6eff59268
Cr-Commit-Position: refs/heads/master@{#431157}

Powered by Google App Engine
This is Rietveld 408576698