Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 2483483003: Remove obsolete code that invalidates document element on LayoutView resize (Closed)

Created:
4 years, 1 month ago by Xianzhu
Modified:
4 years, 1 month ago
Reviewers:
chrishtr, trchen
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove obsolete code that invalidates document element on LayoutView resize The code was needed when the document element painted viewport background. Now ViewPainter paint viewport background, and we invalidate LayoutView itself on its resize. BUG=475115 Committed: https://crrev.com/1bddf0ae1615f5c67ca034d7e08dfdb1ea5846c4 Cr-Commit-Position: refs/heads/master@{#430097}

Patch Set 1 #

Patch Set 2 : Rebaseline #

Patch Set 3 : Rebaseline-cl #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -684 lines) Patch
M third_party/WebKit/LayoutTests/paint/invalidation/border-radius-repaint-2-expected.txt View 1 2 chunks +0 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/fixed-and-absolute-position-scrolled-expected.txt View 1 2 chunks +0 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/scrolled-iframe-scrollbar-change-expected.txt View 1 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/shift-relative-positioned-container-with-image-addition-expected.txt View 1 2 4 chunks +1 line, -15 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/shift-relative-positioned-container-with-image-removal-expected.txt View 1 2 2 chunks +0 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/window-resize-background-image-fixed-centered-composited-expected.txt View 1 8 chunks +0 lines, -36 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/window-resize-background-image-fixed-centered-expected.txt View 1 8 chunks +0 lines, -36 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/window-resize-background-image-generated-expected.txt View 1 8 chunks +0 lines, -36 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/window-resize-background-image-non-fixed-expected.txt View 1 8 chunks +0 lines, -36 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/window-resize-centered-inline-under-fixed-pos-expected.txt View 1 8 chunks +0 lines, -36 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/window-resize-media-query-expected.txt View 1 8 chunks +0 lines, -36 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/window-resize-percent-html-expected.txt View 1 8 chunks +0 lines, -36 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/window-resize-percent-width-height-expected.txt View 1 4 chunks +0 lines, -16 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/window-resize-positioned-bottom-expected.txt View 1 4 chunks +0 lines, -16 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/window-resize-positioned-percent-top-expected.txt View 1 4 chunks +0 lines, -16 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/window-resize-viewport-percent-expected.txt View 1 4 chunks +0 lines, -16 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/abspos-shift-image-incorrect-repaint-expected.txt View 1 2 chunks +0 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/compositing/iframe-inside-squashed-layer-expected.txt View 1 2 chunks +0 lines, -14 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/line-flow-with-floats-2-expected.txt View 1 2 chunks +0 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/line-flow-with-floats-8-expected.txt View 1 2 chunks +0 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/shift-relative-positioned-container-with-image-addition-expected.txt View 1 4 chunks +1 line, -15 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/shift-relative-positioned-container-with-image-removal-expected.txt View 1 2 chunks +0 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/table-shrink-row-repaint-expected.txt View 1 2 chunks +0 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/text-match-document-change-expected.txt View 1 2 chunks +0 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/window-resize-vertical-writing-mode-expected.txt View 1 8 chunks +0 lines, -42 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/abspos-shift-image-incorrect-repaint-expected.txt View 1 2 2 chunks +0 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/compositing/iframe-inside-squashed-layer-expected.txt View 1 2 2 chunks +0 lines, -14 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/line-flow-with-floats-9-expected.txt View 1 2 2 chunks +0 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/table-shrink-row-repaint-expected.txt View 1 2 2 chunks +0 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/text-match-document-change-expected.txt View 1 2 2 chunks +0 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/window-resize-vertical-writing-mode-expected.txt View 1 2 8 chunks +0 lines, -42 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/paint/invalidation/abspos-shift-image-incorrect-repaint-expected.txt View 1 2 2 chunks +0 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/paint/invalidation/compositing/iframe-inside-squashed-layer-expected.txt View 1 2 2 chunks +0 lines, -14 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/paint/invalidation/line-flow-with-floats-9-expected.txt View 1 2 2 chunks +0 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/paint/invalidation/table-shrink-row-repaint-expected.txt View 1 2 2 chunks +0 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/paint/invalidation/text-match-document-change-expected.txt View 1 2 2 chunks +0 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/paint/invalidation/window-resize-vertical-writing-mode-expected.txt View 1 2 8 chunks +0 lines, -42 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutView.cpp View 2 chunks +0 lines, -13 lines 0 comments Download

Messages

Total messages: 19 (12 generated)
Xianzhu
4 years, 1 month ago (2016-11-04 21:47:05 UTC) #7
chrishtr
Looks good to me. Please double-check with Tien-Ren that the hypothesis is correct.
4 years, 1 month ago (2016-11-04 22:33:57 UTC) #8
trchen
lgtm. The deleted code is wrong for many reasons. The only worry I have is ...
4 years, 1 month ago (2016-11-04 22:47:18 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2483483003/40001
4 years, 1 month ago (2016-11-04 23:15:30 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-05 00:44:39 UTC) #16
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/1bddf0ae1615f5c67ca034d7e08dfdb1ea5846c4 Cr-Commit-Position: refs/heads/master@{#430097}
4 years, 1 month ago (2016-11-05 00:47:52 UTC) #18
Xianzhu
3 years, 11 months ago (2017-01-13 20:32:28 UTC) #19
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2634613002/ by wangxianzhu@chromium.org.

The reason for reverting is: Caused bug 680745. Revert first and then work on
the correct fix.

BUG=680745.

Powered by Google App Engine
This is Rietveld 408576698