Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Side by Side Diff: chrome/browser/about_flags.cc

Issue 2483463002: [Offline Pages] Feature flag to allow concurrent background loading on svelte (Closed)
Patch Set: Added flag to LoginCustomFlags histogram Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/about_flags.h" 5 #include "chrome/browser/about_flags.h"
6 6
7 #include <iterator> 7 #include <iterator>
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <utility> 10 #include <utility>
(...skipping 2067 matching lines...) Expand 10 before | Expand all | Expand 10 after
2078 #if BUILDFLAG(ENABLE_PRINT_PREVIEW) 2078 #if BUILDFLAG(ENABLE_PRINT_PREVIEW)
2079 {"print-scaling", IDS_FLAGS_PRINT_SCALING_NAME, 2079 {"print-scaling", IDS_FLAGS_PRINT_SCALING_NAME,
2080 IDS_FLAGS_PRINT_SCALING_DESCRIPTION, kOsDesktop, 2080 IDS_FLAGS_PRINT_SCALING_DESCRIPTION, kOsDesktop,
2081 FEATURE_VALUE_TYPE(features::kPrintScaling)}, 2081 FEATURE_VALUE_TYPE(features::kPrintScaling)},
2082 #endif // !defined(OS_ANDROID) 2082 #endif // !defined(OS_ANDROID)
2083 #if defined(OS_ANDROID) 2083 #if defined(OS_ANDROID)
2084 {"enable-consistent-omnibox-geolocation", 2084 {"enable-consistent-omnibox-geolocation",
2085 IDS_FLAGS_ENABLE_CONSISTENT_OMNIBOX_GEOLOCATION_NAME, 2085 IDS_FLAGS_ENABLE_CONSISTENT_OMNIBOX_GEOLOCATION_NAME,
2086 IDS_FLAGS_ENABLE_CONSISTENT_OMNIBOX_GEOLOCATION_DESCRIPTION, kOsAndroid, 2086 IDS_FLAGS_ENABLE_CONSISTENT_OMNIBOX_GEOLOCATION_DESCRIPTION, kOsAndroid,
2087 FEATURE_VALUE_TYPE(features::kConsistentOmniboxGeolocation)}, 2087 FEATURE_VALUE_TYPE(features::kConsistentOmniboxGeolocation)},
2088 {"concurrent-background-loading-on-svelte",
2089 IDS_FLAGS_OFFLINE_PAGES_SVELTE_CONCURRENT_LOADING_NAME,
2090 IDS_FLAGS_OFFLINE_PAGES_SVELTE_CONCURRENT_LOADING_DESCRIPTION, kOsAndroid,
2091 FEATURE_VALUE_TYPE(
2092 offline_pages::kOfflinePagesSvelteConcurrentLoadingFeature)},
2088 #endif 2093 #endif
2089 // NOTE: Adding new command-line switches requires adding corresponding 2094 // NOTE: Adding new command-line switches requires adding corresponding
2090 // entries to enum "LoginCustomFlags" in histograms.xml. See note in 2095 // entries to enum "LoginCustomFlags" in histograms.xml. See note in
2091 // histograms.xml and don't forget to run AboutFlagsHistogramTest unit test. 2096 // histograms.xml and don't forget to run AboutFlagsHistogramTest unit test.
2092 }; 2097 };
2093 2098
2094 class FlagsStateSingleton { 2099 class FlagsStateSingleton {
2095 public: 2100 public:
2096 FlagsStateSingleton() 2101 FlagsStateSingleton()
2097 : flags_state_(kFeatureEntries, arraysize(kFeatureEntries)) {} 2102 : flags_state_(kFeatureEntries, arraysize(kFeatureEntries)) {}
(...skipping 189 matching lines...) Expand 10 before | Expand all | Expand 10 after
2287 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0; 2292 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0;
2288 2293
2289 const FeatureEntry* GetFeatureEntries(size_t* count) { 2294 const FeatureEntry* GetFeatureEntries(size_t* count) {
2290 *count = arraysize(kFeatureEntries); 2295 *count = arraysize(kFeatureEntries);
2291 return kFeatureEntries; 2296 return kFeatureEntries;
2292 } 2297 }
2293 2298
2294 } // namespace testing 2299 } // namespace testing
2295 2300
2296 } // namespace about_flags 2301 } // namespace about_flags
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698